subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kot...@apache.org
Subject svn commit: r1741097 - /subversion/trunk/subversion/libsvn_subr/sqlite.c
Date Tue, 26 Apr 2016 20:23:09 GMT
Author: kotkov
Date: Tue Apr 26 20:23:09 2016
New Revision: 1741097

URL: http://svn.apache.org/viewvc?rev=1741097&view=rev
Log:
Adjust a couple of comments.

* subversion/libsvn_subr/sqlite.c
  (svn_sqlite__finish_savepoint): Fix an outdated comment.  Add a todo
   about handling errors that can happen when we release sqlite savepoints.

Modified:
    subversion/trunk/subversion/libsvn_subr/sqlite.c

Modified: subversion/trunk/subversion/libsvn_subr/sqlite.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/sqlite.c?rev=1741097&r1=1741096&r2=1741097&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/sqlite.c (original)
+++ subversion/trunk/subversion/libsvn_subr/sqlite.c Tue Apr 26 20:23:09 2016
@@ -1406,7 +1406,7 @@ svn_sqlite__finish_savepoint(svn_sqlite_
               /* Ok, we have a major problem. Some statement is still open,
                  which makes it impossible to release this savepoint.
 
-                 ### See huge comment in svn_sqlite__finish_transaction for
+                 ### See huge comment in rollback_transaction() for
                      further details */
 
               err2 = svn_error_trace(reset_all_statements(db, err2));
@@ -1429,6 +1429,8 @@ svn_sqlite__finish_savepoint(svn_sqlite_
   SVN_ERR(get_internal_statement(&stmt, db,
                                  STMT_INTERNAL_RELEASE_SAVEPOINT_SVN));
 
+  /* ### Releasing a savepoint can fail and leave the db connection
+         unusable; see svn_sqlite__finish_transaction(). */
   return svn_error_trace(svn_sqlite__step_done(stmt));
 }
 



Mime
View raw message