subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From br...@apache.org
Subject svn commit: r1740792 - /subversion/branches/authzperf/subversion/libsvn_repos/log.c
Date Mon, 25 Apr 2016 10:29:22 GMT
Author: brane
Date: Mon Apr 25 10:29:22 2016
New Revision: 1740792

URL: http://svn.apache.org/viewvc?rev=1740792&view=rev
Log:
On the authzperf branch: Remove an early initialization. No functional change.

* subversion/libsvn_repos/log.c (detect_changed):
   Do not initialize 'changes' at declaration time.

Note: This may seem like a trivial nitpick, but I find it easier to
understand that the way 'changes' is initialized depends on whether
we were given any preferched changes or not.

Modified:
    subversion/branches/authzperf/subversion/libsvn_repos/log.c

Modified: subversion/branches/authzperf/subversion/libsvn_repos/log.c
URL: http://svn.apache.org/viewvc/subversion/branches/authzperf/subversion/libsvn_repos/log.c?rev=1740792&r1=1740791&r2=1740792&view=diff
==============================================================================
--- subversion/branches/authzperf/subversion/libsvn_repos/log.c (original)
+++ subversion/branches/authzperf/subversion/libsvn_repos/log.c Mon Apr 25 10:29:22 2016
@@ -352,7 +352,7 @@ detect_changed(svn_repos_revision_access
                void *authz_read_baton,
                apr_pool_t *pool)
 {
-  apr_hash_t *changes = prefetched_changes;
+  apr_hash_t *changes;
   apr_hash_index_t *hi;
   apr_pool_t *iterpool;
   svn_boolean_t found_readable = FALSE;
@@ -361,7 +361,7 @@ detect_changed(svn_repos_revision_access
   /* If we create the CHANGES hash ourselves, we can reuse it as the
    * result hash as it contains the exact same keys - but with _all_
    * values being replaced by structs of a different type. */
-  if (changes == NULL)
+  if (prefetched_changes == NULL)
     {
       SVN_ERR(svn_fs_paths_changed2(&changes, root, pool));
 
@@ -374,6 +374,7 @@ detect_changed(svn_repos_revision_access
     }
   else
     {
+      changes = prefetched_changes;
       *changed = svn_hash__make(pool);
     }
 



Mime
View raw message