subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko ─îibej <>
Subject Re: svn commit: r1712223 - /subversion/trunk/subversion/mod_dav_svn/util.c
Date Tue, 03 Nov 2015 08:31:13 GMT
On 03.11.2015 09:12, wrote:
> Author: ivan
> Date: Tue Nov  3 08:12:36 2015
> New Revision: 1712223
> URL:
> Log:
> Do not insert newlines in base64 encoded responses in mod_dav_svn. This is
> slightly reduce CPU usage on the client since it could decode responses with
> bigger chunks instead line-by-line.

This looks like one of those micro-optimisations that you like to
complain about ... does it really make a measurable difference? A sane
Base64 decoder should just ignore any newlines in the encoded stream and
not try to split it into lines first. If our decoder /does/ read the
response line-by-line, then I propose that's a better place for a
performance improving fix.

The (minor) downside of your change is that it makes it just a bit
harder to read wire dumps.

-- Brane

View raw message