subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From br...@apache.org
Subject svn commit: r1689729 - /subversion/trunk/build/generator/gen_win_dependencies.py
Date Tue, 07 Jul 2015 19:52:54 GMT
Author: brane
Date: Tue Jul  7 19:52:54 2015
New Revision: 1689729

URL: http://svn.apache.org/r1689729
Log:
Make Ruby bindings build on Windows with Visual Studio 2015.

* build/generator/gen_win_dependencies.py
  (SVNCommonLibrary._find_ruby): Do not define snprintf for VS2015+ because
   it's a proper function in that (and presumably newer) versions.

Modified:
    subversion/trunk/build/generator/gen_win_dependencies.py

Modified: subversion/trunk/build/generator/gen_win_dependencies.py
URL: http://svn.apache.org/viewvc/subversion/trunk/build/generator/gen_win_dependencies.py?rev=1689729&r1=1689728&r2=1689729&view=diff
==============================================================================
--- subversion/trunk/build/generator/gen_win_dependencies.py (original)
+++ subversion/trunk/build/generator/gen_win_dependencies.py Tue Jul  7 19:52:54 2015
@@ -958,9 +958,11 @@ class GenDependenciesBase(gen_base.Gener
     if not lib_dir:
       return
 
-    # Visual C++ doesn't have a standard compliant snprintf yet
-    # (Will probably be added in VS2013 + 1)
-    defines = ['snprintf=_snprintf']
+    # Visual C++ prior to VS2015 doesn't have a standard compliant snprintf
+    if self.vs_version < '2015':
+      defines = ['snprintf=_snprintf']
+    else:
+      defines = []
 
     ver = ruby_version.split('.')
     ver = tuple(map(int, ver))



Mime
View raw message