subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stef...@apache.org
Subject svn commit: r1676140 - in /subversion/branches/1.10-cache-improvements/subversion: include/private/svn_pseudo_md5.h libsvn_subr/pseudo_md5.c tests/libsvn_subr/checksum-test.c
Date Sun, 26 Apr 2015 19:11:11 GMT
Author: stefan2
Date: Sun Apr 26 19:11:11 2015
New Revision: 1676140

URL: http://svn.apache.org/r1676140
Log:
On the 1.10-cache-improvements branch:
Remove the now unused pseudo-MD5 functions. It is unlikely that we will
need them again any time soon.

* subversion/include/private/svn_pseudo_md5.h
  Remove declaration file.

* subversion/libsvn_subr/pseudo_md5.c:
  Remove implementation file.

* subversion/tests/libsvn_subr/checksum-test.c
  (test_pseudo_md5): Remove test.
  (test_funcs): Unregister test.

Removed:
    subversion/branches/1.10-cache-improvements/subversion/include/private/svn_pseudo_md5.h
    subversion/branches/1.10-cache-improvements/subversion/libsvn_subr/pseudo_md5.c
Modified:
    subversion/branches/1.10-cache-improvements/subversion/tests/libsvn_subr/checksum-test.c

Modified: subversion/branches/1.10-cache-improvements/subversion/tests/libsvn_subr/checksum-test.c
URL: http://svn.apache.org/viewvc/subversion/branches/1.10-cache-improvements/subversion/tests/libsvn_subr/checksum-test.c?rev=1676140&r1=1676139&r2=1676140&view=diff
==============================================================================
--- subversion/branches/1.10-cache-improvements/subversion/tests/libsvn_subr/checksum-test.c
(original)
+++ subversion/branches/1.10-cache-improvements/subversion/tests/libsvn_subr/checksum-test.c
Sun Apr 26 19:11:11 2015
@@ -27,7 +27,6 @@
 
 #include "svn_error.h"
 #include "svn_io.h"
-#include "private/svn_pseudo_md5.h"
 
 #include "../svn_test.h"
 
@@ -92,38 +91,6 @@ test_checksum_empty(apr_pool_t *pool)
   return SVN_NO_ERROR;
 }
 
-static svn_error_t *
-test_pseudo_md5(apr_pool_t *pool)
-{
-  apr_uint32_t input[16] = { 0 };
-  apr_uint32_t digest_15[4] = { 0 };
-  apr_uint32_t digest_31[4] = { 0 };
-  apr_uint32_t digest_63[4] = { 0 };
-  svn_checksum_t *checksum;
-
-  /* input is all 0s but the hash shall be different
-     (due to different input sizes)*/
-  svn__pseudo_md5_15(digest_15, input);
-  svn__pseudo_md5_31(digest_31, input);
-  svn__pseudo_md5_63(digest_63, input);
-
-  SVN_TEST_ASSERT(memcmp(digest_15, digest_31, sizeof(digest_15)));
-  SVN_TEST_ASSERT(memcmp(digest_15, digest_63, sizeof(digest_15)));
-  SVN_TEST_ASSERT(memcmp(digest_31, digest_63, sizeof(digest_15)));
-
-  /* the checksums shall also be different from "proper" MD5 */
-  SVN_ERR(svn_checksum(&checksum, svn_checksum_md5, input, 15, pool));
-  SVN_TEST_ASSERT(memcmp(digest_15, checksum->digest, sizeof(digest_15)));
-
-  SVN_ERR(svn_checksum(&checksum, svn_checksum_md5, input, 31, pool));
-  SVN_TEST_ASSERT(memcmp(digest_31, checksum->digest, sizeof(digest_15)));
-
-  SVN_ERR(svn_checksum(&checksum, svn_checksum_md5, input, 63, pool));
-  SVN_TEST_ASSERT(memcmp(digest_63, checksum->digest, sizeof(digest_15)));
-
-  return SVN_NO_ERROR;
-}
-
 /* Verify that "zero" checksums work properly for the given checksum KIND.
  */
 static svn_error_t *
@@ -298,8 +265,6 @@ static struct svn_test_descriptor_t test
                    "checksum parse"),
     SVN_TEST_PASS2(test_checksum_empty,
                    "checksum emptiness"),
-    SVN_TEST_PASS2(test_pseudo_md5,
-                   "pseudo-md5 compatibility"),
     SVN_TEST_PASS2(zero_match,
                    "zero checksum matching"),
     SVN_TEST_OPTS_PASS(zlib_expansion_test,



Mime
View raw message