subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache subversion Wiki <comm...@subversion.apache.org>
Subject [Subversion Wiki] Update of "Svn19ApiReview" by PhilipMartin
Date Mon, 30 Mar 2015 17:49:35 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Subversion Wiki" for change notification.

The "Svn19ApiReview" page has been changed by PhilipMartin:
https://wiki.apache.org/subversion/Svn19ApiReview?action=diff&rev1=15&rev2=16

   * `svn_fs_commit_txn` — Is the `SVN_FS_TXN_CLIENT_DATE` behavior still as described?
Yes. Do we want to mention here that this is a 1.9 extension? SVN_FS_TXN_CLIENT_DATE is marked
new in 1.9.
   * `svn_fs_lock_target_create` — `pool` parameter: Is this a `result_pool` or should it
even become 2 pools?Renamed result_pool.
   * `svn_fs_lock_callback_t` — `pool` parameter: Maybe rename to `scratch_pool`. Renamed
scratch_pool.
-  * `svn_fs_lock_many`, `svn_fs_unlock_many` — Mention in docstring that these are not
atomic operations. If the callback returns an error, they simply return that error to their
callers and leave part of the locks in their initial and the remainder in the final state.
What is the lock error handling in case of `lock_callback==NULL`?
+  * `svn_fs_lock_many`, `svn_fs_unlock_many` — Mention in docstring that these are not
atomic operations. If the callback returns an error, they simply return that error to their
callers and leave part of the locks in their initial and the remainder in the final state.
What is the lock error handling in case of `lock_callback==NULL`?Doc updated.
   * `svn_fs_unlock_many` — What is the `result_pool` being used for? As for svn_fs_lock_many,
it it used to allocate the result data passed to the callback.
  
  === svn_ra_svn.h ===
@@ -37, +37 @@

  
  === svn_repos.h ===
   * `svn_repos_notify_warning_t` — Maybe change docstring: "... type of ''warning'' ''triggered''
..."?
-  * `svn_repos_fs_lock_many` — Lock error handling in case of `lock_callback==NULL`? What
is the error return on pre-lock hook failure?
+  * `svn_repos_fs_lock_many` — Lock error handling in case of `lock_callback==NULL`? What
is the error return on pre-lock hook failure?Doc updated.
-  * `svn_repos_fs_unlock_many` — Lock error handling in case of `lock_callback==NULL`?
Error return on pre-unlock hook failure? Why are the paths for callbacks allocated in `result_pool`?
+  * `svn_repos_fs_unlock_many` — Lock error handling in case of `lock_callback==NULL`?
Error return on pre-unlock hook failure? Doc updated. Why are the paths for callbacks allocated
in `result_pool`?The paths are part of the "result" passed to the callback, just like the
lock and path in the svn_fs_lock_many.
   * `svn_repos_parse_dumpstream3` — [JAF] Comment.
    * Comment still applies. — JAF
   * `svn_repos_get_fs_build_parser5` — Handling of / behavior if `use_history==FALSE`?

Mime
View raw message