subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache subversion Wiki <comm...@subversion.apache.org>
Subject [Subversion Wiki] Update of "Svn19ApiReview" by JulianFoad
Date Tue, 24 Mar 2015 17:09:22 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Subversion Wiki" for change notification.

The "Svn19ApiReview" page has been changed by JulianFoad:
https://wiki.apache.org/subversion/Svn19ApiReview?action=diff&rev1=12&rev2=13

  
  ----
  == Needs Review ==
- 
  All public API headers have been reviewed at least once.
  
  ----
@@ -17, +16 @@

   * `svn_client_cleanup2` — Missing documentation for arguments `fix_recorded_timestamps`,
`clear_dav_cache` and `vacuum_pristines`. (svn praise: r1548088 rhuijben)
   * `svn_client_cleanup`  — Missing SVN_DEPRECATED annotation.
  
- 
  === svn_diff.h ===
- 
   * `svn_diff_output2`
   * `svn_diff_file_output_unified4`
   * `svn_diff_output_binary`
@@ -39, +36 @@

   * `svn_fs_unlock_many` — What is the `result_pool` being used for?
  
  === svn_ra_svn.h ===
- 
   * `svn_ra_svn_create_conn4` — The @note is unclear. Is the file being used for time-out
detection?
  
  === svn_repos.h ===
- 
   * `svn_repos_notify_warning_t` — Maybe change docstring: "... type of ''warning'' ''triggered''
..."?
   * `svn_repos_fs_lock_many` — Lock error handling in case of `lock_callback==NULL`? What
is the error return on pre-lock hook failure?
   * `svn_repos_fs_unlock_many` — Lock error handling in case of `lock_callback==NULL`?
Error return on pre-unlock hook failure? Why are the paths for callbacks allocated in `result_pool`?
   * `svn_repos_parse_dumpstream3` — [JAF] Comment.
+   * Comment still applies. — JAF
   * `svn_repos_get_fs_build_parser5` — Handling of / behavior if `use_history==FALSE`?
  
  === svn_types.h ===
   * `svn_null_pointer_constant_stdarg_sentinel_t` — Should this be private?
-    * No; the idea is that API users can use `SVN_VA_NULL`. Note that the definition is a
forward declaration of the type for the purpose of making it a pointer constant that's not
trivially assignable to anything else (except `void*`), but the type itself is never defined,
on purpose. — brane
+   * No; the idea is that API users can use `SVN_VA_NULL`. Note that the definition is a
forward declaration of the type for the purpose of making it a pointer constant that's not
trivially assignable to anything else (except `void*`), but the type itself is never defined,
on purpose. — brane
- 
  
  === svn_wc.h ===
- 
   * `svn_wc_notify_move_broken` — Has a TODO left-over from 1.8
   * `svn_wc_conflict_description2_t.merged_file` — Clarify the ###.
   * `svn_wc_conflict_description_create_tree2` — What is that @c local_node_kind that is
being mentioned _twice_?
@@ -69, +63 @@

  
  ----
  == Review Completed! ==
- 
  These headers have been reviewed by stefan2 and where issues have been found, they are already
fixed.  More review is welcome.
  
   . mod_dav_svn.h
@@ -80, +73 @@

   . svn_mergeinfo.h
   . svn_ra.h
   . svn_string.h
-  . svn_version.h  
+  . svn_version.h
  
  The following 1.9 header contain only minor changes against 1.8.  Those changes seem to
be o.k.  Reviewed by stefan2.
  

Mime
View raw message