subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache subversion Wiki <>
Subject [Subversion Wiki] Update of "Svn19ApiReview" by StefanFuhrmann
Date Mon, 16 Mar 2015 19:40:28 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Subversion Wiki" for change notification.

The "Svn19ApiReview" page has been changed by StefanFuhrmann:

Add issues found during the review of svn_fs.h and svn_repos.h.

  === svn_dirent_uri.h ===
   * `svn_relpath_limit` — Is this really a good public API, either in functionality or
in name? I  suggest it should be a local function in the one file where it's used,  or else
made private and named 'svn_relpath__first_n_components'.
+ === svn_fs.h ===
+  * `svn_fs_commit_txn` — Is the `SVN_FS_TXN_CLIENT_DATE` behavior still as described?
Do we want to mention here that this is a 1.9 extension?
+  * `svn_fs_dir_optimal_order` — Should use 2 pools as its implementation creates temporary
+  * `svn_fs_lock_target_create` — `pool` parameter: Is this a `result_pool` or should it
even become 2 pools?
+  * `svn_fs_lock_callback_t` — `pool` parameter: Maybe rename to `scratch_pool`.
+  * `svn_fs_lock_many`, `svn_fs_unlock_many` — Mention in docstring that these are not
atomic operations. If the callback returns an error, they simply return that error to their
callers and leave part of the locks in their initial and the remainder in the final state.
What is the lock error handling in case of `lock_callback==NULL`?
+  * `svn_fs_unlock_many` — What is the `result_pool` being used for?
+ === svn_repos.h ===
+  * `svn_repos_notify_warning_t` — Maybe change docstring: "... type of ''warning'' ''triggered''
+  * `svn_repos_fs_lock_many` — Lock error handling in case of `lock_callback==NULL`? What
is the error return on pre-lock hook failure?
+  * `svn_repos_fs_unlock_many` — Lock error handling in case of `lock_callback==NULL`?
Error return on pre-unlock hook failure? Why are the paths for callbacks allocated in `result_pool`?
+  * `svn_repos_parse_dumpstream3` — [JAF] Comment.
+  * `svn_repos_get_fs_build_parser5` — Handling of / behavior if `use_history==FALSE`?
  === svn_types.h ===
   * `svn_null_pointer_constant_stdarg_sentinel_t` — Should this be private?
     * No; the idea is that API users can use `SVN_VA_NULL`. Note that the definition is a
forward declaration of the type for the purpose of making it a pointer constant that's not
trivially assignable to anything else (except `void*`), but the type itself is never defined,
on purpose. — brane

View raw message