subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Fuhrmann <stefan.fuhrm...@wandisco.com>
Subject Re: svn commit: r1622946 - /subversion/trunk/subversion/libsvn_fs_fs/rev_file.c
Date Mon, 08 Sep 2014 12:24:19 GMT
On Sun, Sep 7, 2014 at 10:30 AM, Branko ─îibej <brane@wandisco.com> wrote:

> On 07.09.2014 00:01, stefan2@apache.org wrote:
> > --- subversion/trunk/subversion/libsvn_fs_fs/rev_file.c (original)
> > +++ subversion/trunk/subversion/libsvn_fs_fs/rev_file.c Sat Sep  6
> 22:01:09 2014
> > @@ -176,6 +176,9 @@ open_pack_or_rev_file(svn_fs_fs__revisio
> >
> >                /* We failed for the first time. Refresh cache & retry. */
> >                SVN_ERR(svn_fs_fs__update_min_unpacked_rev(fs,
> scratch_pool));
> > +              file->start_revision = rev < ffd->min_unpacked_rev
> > +                                    ? rev - (rev %
> ffd->max_files_per_dir)
> > +                                    : rev;
>
> Even though the precedence rules make this assignment behave as
> intended, I would really, really prefer to have parentheses around the
> ternary expression.
>

Done in combination with some code de-duplication in r1623368.

-- Stefan^2.

Mime
View raw message