subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1618626 - /subversion/trunk/subversion/include/svn_string.h
Date Mon, 18 Aug 2014 15:02:32 GMT
Author: stsp
Date: Mon Aug 18 15:02:32 2014
New Revision: 1618626

URL: http://svn.apache.org/r1618626
Log:
* subversion/include/svn_string.h
  (svn_cstring_strtoi64, svn_cstring_atoi64, svn_cstring_atoi,
   svn_cstring_strtoui64, svn_cstring_atoui64, svn_cstring_atoui): Explicitly
    document the fact that these functions skip leading whitespace. This is
    because they were implemented with strtol(). In retrospect it would have
    been better to implement these functions without whitespace recognitition.
    However, changing this behaviour now is difficult because callers might
    already rely on it.

Modified:
    subversion/trunk/subversion/include/svn_string.h

Modified: subversion/trunk/subversion/include/svn_string.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_string.h?rev=1618626&r1=1618625&r2=1618626&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_string.h (original)
+++ subversion/trunk/subversion/include/svn_string.h Mon Aug 18 15:02:32 2014
@@ -524,6 +524,7 @@ svn_cstring_casecmp(const char *str1, co
  * Parse the C string @a str into a 64 bit number, and return it in @a *n.
  * Assume that the number is represented in base @a base.
  * Raise an error if conversion fails (e.g. due to overflow), or if the
+ * Leading whitespace in @a str is skipped in a locale-dependent way.
  * converted number is smaller than @a minval or larger than @a maxval.
  *
  * @since New in 1.7.
@@ -537,6 +538,7 @@ svn_cstring_strtoi64(apr_int64_t *n, con
  * Parse the C string @a str into a 64 bit number, and return it in @a *n.
  * Assume that the number is represented in base 10.
  * Raise an error if conversion fails (e.g. due to overflow).
+ * Leading whitespace in @a str is skipped in a locale-dependent way.
  *
  * @since New in 1.7.
  */
@@ -547,6 +549,7 @@ svn_cstring_atoi64(apr_int64_t *n, const
  * Parse the C string @a str into a 32 bit number, and return it in @a *n.
  * Assume that the number is represented in base 10.
  * Raise an error if conversion fails (e.g. due to overflow).
+ * Leading whitespace in @a str is skipped in a locale-dependent way.
  *
  * @since New in 1.7.
  */
@@ -558,6 +561,7 @@ svn_cstring_atoi(int *n, const char *str
  * it in @a *n. Assume that the number is represented in base @a base.
  * Raise an error if conversion fails (e.g. due to overflow), or if the
  * converted number is smaller than @a minval or larger than @a maxval.
+ * Leading whitespace in @a str is skipped in a locale-dependent way.
  *
  * @since New in 1.7.
  */
@@ -570,6 +574,7 @@ svn_cstring_strtoui64(apr_uint64_t *n, c
  * Parse the C string @a str into an unsigned 64 bit number, and return
  * it in @a *n. Assume that the number is represented in base 10.
  * Raise an error if conversion fails (e.g. due to overflow).
+ * Leading whitespace in @a str is skipped in a locale-dependent way.
  *
  * @since New in 1.7.
  */
@@ -580,6 +585,7 @@ svn_cstring_atoui64(apr_uint64_t *n, con
  * Parse the C string @a str into an unsigned 32 bit number, and return
  * it in @a *n. Assume that the number is represented in base 10.
  * Raise an error if conversion fails (e.g. due to overflow).
+ * Leading whitespace in @a str is skipped in a locale-dependent way.
  *
  * @since New in 1.7.
  */



Mime
View raw message