subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhuij...@apache.org
Subject svn commit: r1607063 - /subversion/trunk/subversion/libsvn_diff/diff_file.c
Date Tue, 01 Jul 2014 12:55:08 GMT
Author: rhuijben
Date: Tue Jul  1 12:55:08 2014
New Revision: 1607063

URL: http://svn.apache.org/r1607063
Log:
Following up on r1485488, remove unneeded && expression which is already part
of the loop condition.

* subversion/libsvn_diff/diff_file.c
  (find_identical_suffix): Remove unnecessary operation.

Modified:
    subversion/trunk/subversion/libsvn_diff/diff_file.c

Modified: subversion/trunk/subversion/libsvn_diff/diff_file.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_diff/diff_file.c?rev=1607063&r1=1607062&r2=1607063&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_diff/diff_file.c (original)
+++ subversion/trunk/subversion/libsvn_diff/diff_file.c Tue Jul  1 12:55:08 2014
@@ -649,10 +649,9 @@ find_identical_suffix(apr_off_t *suffix_
 
       /* Scan quickly by reading with machine-word granularity. */
       for (i = 0, can_read_word = TRUE; can_read_word && i < file_len; i++)
-        can_read_word = can_read_word
-                        && (  (file_for_suffix[i].curp + 1
-                                 - sizeof(apr_uintptr_t))
-                            > min_curp[i]);
+        can_read_word = ((file_for_suffix[i].curp + 1 - sizeof(apr_uintptr_t))
+                         > min_curp[i]);
+
       while (can_read_word)
         {
           apr_uintptr_t chunk;
@@ -667,8 +666,7 @@ find_identical_suffix(apr_off_t *suffix_
             break;
 
           for (i = 1, is_match = TRUE; is_match && i < file_len; i++)
-            is_match = is_match
-                       && (   chunk
+            is_match = (chunk
                            == *(const apr_uintptr_t *)
                                     (file_for_suffix[i].curp + 1
                                        - sizeof(apr_uintptr_t)));



Mime
View raw message