subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philip Martin <philip.mar...@wandisco.com>
Subject Re: svn commit: r1582845 - /subversion/trunk/subversion/libsvn_fs/fs-loader.c
Date Fri, 28 Mar 2014 19:57:28 GMT
"Bert Huijben" <bert@qqmail.nl> writes:

>> +                     expiration_date, steal_lock, pool, pool);
>> +
>> +  if (apr_hash_count(results))
>
> Is this function explicitly documented to always set the results value
> on all error paths?
>
> I don't see that in the documentation for svn_fs_lock2?

It is now.

> And it is certainly not our standard pattern for public
> functions... By default the output arguments are undefined on error.

It's necessary to allow the caller to handle all the errors.

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*

Mime
View raw message