subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject svn commit: r1575019 - /subversion/trunk/subversion/libsvn_fs_fs/fs.h
Date Thu, 06 Mar 2014 19:17:07 GMT
Author: breser
Date: Thu Mar  6 19:17:07 2014
New Revision: 1575019

Use the correct type for revision numbers.

While yes we're now limiting them to 32-bit effectively (despite the
svn_revnum_t type being wider on many platforms today), we shouldn't be using
a different type anywhere in our code so that we can change the type and not
have to go looking for all the places where we've done things like this.  Yes,
this uses more memory at runtime, but this is the long term consequence of our
type choice for revision numbers.

* subversion/libsvn_fs_fs/fs.h
  (representation_cache_key_t): Use svn_revnum_t instead of apr_uint32_t.


Modified: subversion/trunk/subversion/libsvn_fs_fs/fs.h
--- subversion/trunk/subversion/libsvn_fs_fs/fs.h (original)
+++ subversion/trunk/subversion/libsvn_fs_fs/fs.h Thu Mar  6 19:17:07 2014
@@ -264,7 +264,7 @@ typedef struct pair_cache_key_t
 typedef struct representation_cache_key_t
   /* Revision that contains the representation */
-  apr_uint32_t revision;
+  svn_revnum_t revision;
   /* Packed or non-packed representation? */
   svn_boolean_t is_packed;

View raw message