subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From br...@apache.org
Subject svn commit: r1547248 - /subversion/trunk/subversion/bindings/javahl/native/JNIUtil.cpp
Date Tue, 03 Dec 2013 00:32:40 GMT
Author: brane
Date: Tue Dec  3 00:32:40 2013
New Revision: 1547248

URL: http://svn.apache.org/r1547248
Log:
JavaHL should use the default cache size and let the FS backend decide
what it needs to cache.

* subversion/bindings/javahl/native/JNIUtil.cpp (JNIUtil::JNIGlobalInit):
   Leave the default cache sizes, but do signal that we're multi-threaded.

Modified:
    subversion/trunk/subversion/bindings/javahl/native/JNIUtil.cpp

Modified: subversion/trunk/subversion/bindings/javahl/native/JNIUtil.cpp
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/native/JNIUtil.cpp?rev=1547248&r1=1547247&r2=1547248&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/native/JNIUtil.cpp (original)
+++ subversion/trunk/subversion/bindings/javahl/native/JNIUtil.cpp Tue Dec  3 00:32:40 2013
@@ -245,12 +245,11 @@ bool JNIUtil::JNIGlobalInit(JNIEnv *env)
   svn_fs_initialize(g_pool); /* Avoid some theoretical issues */
   svn_ra_initialize(g_pool);
 
-  /* We shouldn't fill the JVMs memory with FS cache data unless explictly
-     requested. */
+  /* We shouldn't fill the JVMs memory with FS cache data unless
+     explictly requested. And we don't either, because the caches get
+     allocated outside the JVM heap. Duh. */
   {
     svn_cache_config_t settings = *svn_cache_config_get();
-    settings.cache_size = 0;
-    settings.file_handle_count = 0;
     settings.single_threaded = FALSE;
     svn_cache_config_set(&settings);
   }



Mime
View raw message