subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bert Huijben <b...@qqmail.nl>
Subject Re: svn commit: r1543985 - in /subversion/trunk/subversion/bindings/javahl: native/ native/jniwrapper/ src/org/apache/subversion/javahl/types/ src/org/apache/subversion/javahl/util/ tests/org/apache/subversion/javahl/
Date Thu, 21 Nov 2013 02:11:48 GMT
Branko,


I might have found the cause of the error. See snippet below


Bert





Sent from Windows Mail





From: Branko Čibej
Sent: ‎Thursday‎, ‎November‎ ‎21‎, ‎2013 ‎12‎:‎43‎ ‎AM
To: commits@subversion.apache.org


+class KeywordHashBuilder
+{
+public:
+  explicit KeywordHashBuilder(const SVN::Pool& pool)
+    : m_pool(pool),
+      m_hash(apr_hash_make(pool.getPool()))
+    {}
+
+  void operator()(const std::string& key, const Java::ByteArray& value)
+    {
+      Java::ByteArray::Contents val(value);
+      apr_hash_set(m_hash, key.c_str(), key.size(), val.get_string(m_pool));
+    }

<<<<<<<

The key must be duplicated in the pool, or hash lookups will look into memory with unknown
lifetime when they compare the key.

<<<<<<<


+
+  apr_hash_t* get() const
+    {
+      return m_hash;
+    }
+
+private:
+  const SVN::Pool& m_pool;
+  apr_hash_t* const m_hash;
+};
+
Mime
View raw message