subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stef...@apache.org
Subject svn commit: r1545634 - /subversion/trunk/subversion/tests/svn_test_main.c
Date Tue, 26 Nov 2013 12:35:47 GMT
Author: stefan2
Date: Tue Nov 26 12:35:47 2013
New Revision: 1545634

URL: http://svn.apache.org/r1545634
Log:
Trying to address the cleanup issue reported by Brane in
http://svn.haxx.se/dev/archive-2013-11/0198.shtml

Although I cannot reproduce the problem, global pool cleanups
in apr_terminate() are known to be fragile.  Thus, run cleanups
explicitly long before terminating the application.

* subversion/tests/svn_test_main.c
  (do_tests_concurrently): Don't run cleanup here.
  (main): Run cleanups in the same order as in non-threaded mode
          making sure that the apr_thread_pool terminates before
          shutting APR down.

Modified:
    subversion/trunk/subversion/tests/svn_test_main.c

Modified: subversion/trunk/subversion/tests/svn_test_main.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/svn_test_main.c?rev=1545634&r1=1545633&r2=1545634&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/svn_test_main.c (original)
+++ subversion/trunk/subversion/tests/svn_test_main.c Tue Nov 26 12:35:47 2013
@@ -531,9 +531,6 @@ do_tests_concurrently(const char *progna
          || apr_thread_pool_busy_count(threads))
     apr_thread_yield();
 
-  /* Execute all cleanups. */
-  svn_pool_clear(cleanup_pool);
-
   return got_error != FALSE;
 }
 
@@ -876,7 +873,11 @@ main(int argc, const char *argv[])
         {
           got_error = do_tests_concurrently(prog_name, array_size,
                                             svn_test_max_threads,
-                                            &opts, pool);
+                                            &opts, test_pool);
+
+          /* Execute all cleanups */
+          svn_pool_clear(test_pool);
+          svn_pool_clear(cleanup_pool);
         }
 #endif
     }



Mime
View raw message