subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bert Huijben" <b...@qqmail.nl>
Subject RE: svn commit: r1523465 - /subversion/trunk/subversion/svnserve/svnserve.c
Date Sun, 15 Sep 2013 18:07:36 GMT


> -----Original Message-----
> From: stefan2@apache.org [mailto:stefan2@apache.org]
> Sent: zondag 15 september 2013 19:47
> To: commits@subversion.apache.org
> Subject: svn commit: r1523465 -
> /subversion/trunk/subversion/svnserve/svnserve.c
> 
> Author: stefan2
> Date: Sun Sep 15 17:46:36 2013
> New Revision: 1523465
> 
> URL: http://svn.apache.org/r1523465
> Log:
> As it turns out, allocating memory from the OS in a multi-threaded
> environment is relatively costly.  With APR pools, this happens
> every time we use a newly created root pool.
> 
> Therefore, teach svnserve to recycle the connection pools, keeping
> those precious memory blocks allocated instead of disposing and
> re-allocating them.

Is this really the best way to do this?

Can't we create a subpool here? (Or do we also need multiple allocators, etc.)

In the implementation I see that the existing pools are re-used, but they are not *cleared*
before re-use?

Shouldn't we at least release the used memory (and thate) when handing back the memory to
the pool allocator?

	Bert


Mime
View raw message