Return-Path: X-Original-To: apmail-subversion-commits-archive@minotaur.apache.org Delivered-To: apmail-subversion-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B02B51026B for ; Fri, 16 Aug 2013 09:18:52 +0000 (UTC) Received: (qmail 38325 invoked by uid 500); 16 Aug 2013 09:18:52 -0000 Delivered-To: apmail-subversion-commits-archive@subversion.apache.org Received: (qmail 38204 invoked by uid 500); 16 Aug 2013 09:18:43 -0000 Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@subversion.apache.org Delivered-To: mailing list commits@subversion.apache.org Received: (qmail 38196 invoked by uid 99); 16 Aug 2013 09:18:41 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Aug 2013 09:18:41 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Aug 2013 09:18:40 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 0B10D238889B; Fri, 16 Aug 2013 09:18:20 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1514628 - /subversion/trunk/subversion/libsvn_ra_serf/serf.c Date: Fri, 16 Aug 2013 09:18:19 -0000 To: commits@subversion.apache.org From: ivan@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20130816091820.0B10D238889B@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: ivan Date: Fri Aug 16 09:18:19 2013 New Revision: 1514628 URL: http://svn.apache.org/r1514628 Log: Follow-up to r1514315: Avoid potential issue with '%' character in SVN_VER_NUMBER or SVN_BUILD_TARGET. Found by: danielsh * subversion/libsvn_ra_serf/serf.c (get_user_agent_string): Do not use SVN_VER_NUMBER and SVN_BUILD_TARGET in format string. Modified: subversion/trunk/subversion/libsvn_ra_serf/serf.c Modified: subversion/trunk/subversion/libsvn_ra_serf/serf.c URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/serf.c?rev=1514628&r1=1514627&r2=1514628&view=diff ============================================================================== --- subversion/trunk/subversion/libsvn_ra_serf/serf.c (original) +++ subversion/trunk/subversion/libsvn_ra_serf/serf.c Fri Aug 16 09:18:19 2013 @@ -423,8 +423,8 @@ get_user_agent_string(apr_pool_t *pool) int major, minor, patch; serf_lib_version(&major, &minor, &patch); - return apr_psprintf(pool, "SVN/" SVN_VER_NUMBER " (" SVN_BUILD_TARGET ") " - " serf/%d.%d.%d", + return apr_psprintf(pool, "SVN/%s (%s) serf/%d.%d.%d", + SVN_VER_NUMBER, SVN_BUILD_TARGET, major, minor, patch); }