subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Sperling <s...@elego.de>
Subject Re: svn commit: r1517472 - in /subversion/trunk/subversion/libsvn_ra_serf: ra_serf.h update.c util.c
Date Mon, 26 Aug 2013 09:27:04 GMT
On Mon, Aug 26, 2013 at 09:15:45AM -0000, ivan@apache.org wrote:
> Author: ivan
> Date: Mon Aug 26 09:15:44 2013
> New Revision: 1517472
> 
> URL: http://svn.apache.org/r1517472
> Log:
> ra_serf: Remove DAV: headers from GET requests. This decrease outbound 
> traffic during checkout/update by 45%.
> 
> * subversion/libsvn_ra_serf/ra_serf.h
>   (svn_ra_serf__handler_t): Add NO_DAV_HEADERS member.
> 
> * subversion/libsvn_ra_serf/update.c
>   (fetch_file, svn_ra_serf__get_file): Set NO_DAV_HEADERS=TRUE for GET 
>    request.
> 
> * subversion/libsvn_ra_serf/util.c
>   (setup_serf_req): Add DAV: request headers only if DAV_HEADERS parameter
>    is non-zero.
>   (setup_request): Pass ! NO_DAV_HEADERS to setup_serf_req() call.

> @@ -786,9 +790,12 @@ setup_serf_req(serf_request_t *request,
>    /* These headers need to be sent with every request; see issue #3255
>       ("mod_dav_svn does not pass client capabilities to start-commit
>       hooks") for why. */

Can you please update the above comment to justify the exception
made in case dav_headers is FALSE?

> -  serf_bucket_headers_setn(*hdrs_bkt, "DAV", SVN_DAV_NS_DAV_SVN_DEPTH);
> -  serf_bucket_headers_setn(*hdrs_bkt, "DAV", SVN_DAV_NS_DAV_SVN_MERGEINFO);
> -  serf_bucket_headers_setn(*hdrs_bkt, "DAV", SVN_DAV_NS_DAV_SVN_LOG_REVPROPS);
> +  if (dav_headers)
> +    {
> +      serf_bucket_headers_setn(*hdrs_bkt, "DAV", SVN_DAV_NS_DAV_SVN_DEPTH);
> +      serf_bucket_headers_setn(*hdrs_bkt, "DAV", SVN_DAV_NS_DAV_SVN_MERGEINFO);
> +      serf_bucket_headers_setn(*hdrs_bkt, "DAV", SVN_DAV_NS_DAV_SVN_LOG_REVPROPS);
> +    }
>  
>    return SVN_NO_ERROR;
>  }

Mime
View raw message