subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From br...@apache.org
Subject svn commit: r1509153 - in /subversion/trunk/subversion: include/private/svn_subr_private.h libsvn_subr/spillbuf.c tests/libsvn_subr/spillbuf-test.c
Date Thu, 01 Aug 2013 10:02:35 GMT
Author: brane
Date: Thu Aug  1 10:02:34 2013
New Revision: 1509153

URL: http://svn.apache.org/r1509153
Log:
Fix a number of style nits in the spillbuf implementation.

* subversion/include/private/svn_subr_private.h,
  subversion/libsvn_subr/spillbuf.c,
  subversion/tests/libsvn_subr/spillbuf-test.c: According to our style guide
   in declarations * binds to the name, not the type of the variable.

Found by: gstein

Modified:
    subversion/trunk/subversion/include/private/svn_subr_private.h
    subversion/trunk/subversion/libsvn_subr/spillbuf.c
    subversion/trunk/subversion/tests/libsvn_subr/spillbuf-test.c

Modified: subversion/trunk/subversion/include/private/svn_subr_private.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/private/svn_subr_private.h?rev=1509153&r1=1509152&r2=1509153&view=diff
==============================================================================
--- subversion/trunk/subversion/include/private/svn_subr_private.h (original)
+++ subversion/trunk/subversion/include/private/svn_subr_private.h Thu Aug  1 10:02:34 2013
@@ -185,7 +185,7 @@ svn_spillbuf__reader_create_extended(apr
                                      apr_size_t maxsize,
                                      svn_boolean_t delete_on_close,
                                      svn_boolean_t spill_all_contents,
-                                     const char* dirpath,
+                                     const char *dirpath,
                                      apr_pool_t *result_pool);
 
 /* Read @a len bytes from @a reader into @a data. The number of bytes
@@ -234,7 +234,7 @@ svn_stream__from_spillbuf_extended(apr_s
                                    apr_size_t maxsize,
                                    svn_boolean_t delete_on_close,
                                    svn_boolean_t spill_all_contents,
-                                   const char* dirpath,
+                                   const char *dirpath,
                                    apr_pool_t *result_pool);
 
 

Modified: subversion/trunk/subversion/libsvn_subr/spillbuf.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/spillbuf.c?rev=1509153&r1=1509152&r2=1509153&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/spillbuf.c (original)
+++ subversion/trunk/subversion/libsvn_subr/spillbuf.c Thu Aug  1 10:02:34 2013
@@ -120,7 +120,7 @@ init_spillbuf_extended(svn_spillbuf_t *b
                        apr_size_t maxsize,
                        svn_boolean_t delete_on_close,
                        svn_boolean_t spill_all_contents,
-                       const char* dirpath,
+                       const char *dirpath,
                        apr_pool_t *result_pool)
 {
   buf->pool = result_pool;
@@ -160,7 +160,7 @@ svn_spillbuf__create_extended(apr_size_t
                               apr_size_t maxsize,
                               svn_boolean_t delete_on_close,
                               svn_boolean_t spill_all_contents,
-                              const char* dirpath,
+                              const char *dirpath,
                               apr_pool_t *result_pool)
 {
   svn_spillbuf_t *buf = apr_pcalloc(result_pool, sizeof(*buf));
@@ -536,7 +536,7 @@ svn_spillbuf__reader_create_extended(apr
                                      apr_size_t maxsize,
                                      svn_boolean_t delete_on_close,
                                      svn_boolean_t spill_all_contents,
-                                     const char* dirpath,
+                                     const char *dirpath,
                                      apr_pool_t *result_pool)
 {
   svn_spillbuf_reader_t *sbr = apr_pcalloc(result_pool, sizeof(*sbr));
@@ -725,7 +725,7 @@ svn_stream__from_spillbuf_extended(apr_s
                                    apr_size_t maxsize,
                                    svn_boolean_t delete_on_close,
                                    svn_boolean_t spill_all_contents,
-                                   const char* dirpath,
+                                   const char *dirpath,
                                    apr_pool_t *result_pool)
 {
   return stream_from_reader(

Modified: subversion/trunk/subversion/tests/libsvn_subr/spillbuf-test.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/libsvn_subr/spillbuf-test.c?rev=1509153&r1=1509152&r2=1509153&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/libsvn_subr/spillbuf-test.c (original)
+++ subversion/trunk/subversion/tests/libsvn_subr/spillbuf-test.c Thu Aug  1 10:02:34 2013
@@ -546,7 +546,7 @@ test_spillbuf_eof_spill_all(apr_pool_t *
 }
 
 static svn_error_t *
-test_spillbuf__file_attrs(apr_pool_t* pool, svn_boolean_t spill_all,
+test_spillbuf__file_attrs(apr_pool_t *pool, svn_boolean_t spill_all,
                           svn_spillbuf_t *buf)
 {
   apr_finfo_t finfo;
@@ -574,7 +574,7 @@ test_spillbuf__file_attrs(apr_pool_t* po
 }
 
 static svn_error_t *
-test_spillbuf_file_attrs(apr_pool_t* pool)
+test_spillbuf_file_attrs(apr_pool_t *pool)
 {
   svn_spillbuf_t *buf = svn_spillbuf__create(4 /* blocksize */,
                                              10 /* maxsize */,
@@ -583,7 +583,7 @@ test_spillbuf_file_attrs(apr_pool_t* poo
 }
 
 static svn_error_t *
-test_spillbuf_file_attrs_spill_all(apr_pool_t* pool)
+test_spillbuf_file_attrs_spill_all(apr_pool_t *pool)
 {
   svn_spillbuf_t *buf = svn_spillbuf__create_extended(
                           4 /* blocksize */,



Mime
View raw message