Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@subversion.apache.org
Received-SPF: pass (nike.apache.org: local policy)
Date: Mon, 1 Jul 2013 15:05:52 +0300
From: Daniel Shahaf <danielsh@elego.de>
To: dev@subversion.apache.org
Cc: commits@subversion.apache.org
Subject: Re: svn commit: r1498394 - in
	/subversion/branches/verify-keep-going/subversion:
	libsvn_repos/dump.c svnadmin/svnadmin.c
Message-ID: <20130701120552.GD2976@lp-shahaf.local>
References: <20130701120138.9C9D12388980@eris.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130701120138.9C9D12388980@eris.apache.org>
User-Agent: Mutt/1.5.18 (2008-05-17)

prabhugs@apache.org wrote on Mon, Jul 01, 2013 at 12:01:38 -0000:
>    /* Show the summary. */
> -  if (notify_func && keep_going)
> +  if (notify_func && keep_going && found_corruption)
>      {
>        notify_verification_summary(err, notify_func, notify_baton, iterpool);

Thanks.


> +++ subversion/branches/verify-keep-going/subversion/svnadmin/svnadmin.c Mon Jul  1 12:01:38 2013
> @@ -850,13 +850,16 @@ repos_notify_handler(void *baton,
>      case svn_repos_notify_failure_summary:
>        if (notify->revision != SVN_INVALID_REVNUM)
>          cmdline_stream_printf(feedback_stream, scratch_pool,
> -                              _("r%ld: %s\n"),
> -                              notify->revision, notify->err->message);
> +                              _("\nRevision %ld \n"),
> +                              notify->revision);
> +      if (notify->err)
> +        svn_handle_error2(notify->err, stderr, FALSE /* non-fatal */,
> +                          "svnadmin: ");

How about using "svnadmin: r%ld: " as the prefix, for clarity?

Daniel