subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Reser <...@reser.org>
Subject Re: svn commit: r1507044 -
Date Thu, 25 Jul 2013 22:45:16 GMT
On Thu, Jul 25, 2013 at 3:37 PM, Bert Huijben <bert@qqmail.nl> wrote:
> If svn_hash_sets doesn't have a return value we could redefine it with
> a temporary variable (and catch some type warnings too)

Yup, apr_hash_set() has a void return.  So we could still fix this
with the macro.

Does this look okay?
#define svn_hash_sets(ht, key_expression, val) \
  do { \
    const char *key = key_expression; \
    apr_hash_set(ht, key, strlen(key), val); \
  } while (0)

Mime
View raw message