subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@gmail.com>
Subject Re: svn commit: r1502401 - in /subversion/branches/tristate-chunked-request/subversion: include/svn_config.h libsvn_ra_serf/serf.c libsvn_ra_serf/util.c libsvn_subr/config_file.c
Date Fri, 12 Jul 2013 01:42:08 GMT
On Thu, Jul 11, 2013 at 8:11 PM,  <breser@apache.org> wrote:
> Author: breser
> Date: Fri Jul 12 00:11:48 2013
> New Revision: 1502401
>
> URL: http://svn.apache.org/r1502401
> Log:
> Reimplement the tristate http-chunked-requests config option on top of the
> latest trunk implementation of boolean http-detect-chunking.

Ugh. Why the rename? I spent a bunch of effort bringing the name in
line with dev@ thinking. This option primarily controls if/when we
detect for chunked request capability on the connection.

>...
> * subversion/libsvn_ra_serf/serf.c
>   (load_config): Switch to using the tristate option.

If keeping a tristate, then yeah. I think this is the right
implementation. Very clean, and we have the ability to spread the
detection across ra_serf rather than a spurious/additional OPTIONS
request.

>...

Much of this revision deals with changing the option name. I'm tending
to disagree with that change.

On the tri-state itself... I'll start a new thread.

Cheers,
-g

Mime
View raw message