subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko ─îibej <>
Subject Re: svn commit: r1508170 - in /subversion/trunk: build/ac-macros/svn-macros.m4 subversion/include/svn_hash.h
Date Tue, 30 Jul 2013 23:29:30 GMT
On 30.07.2013 15:57, Daniel Shahaf wrote:
> r1508225: changing the include order //only in places that currently
> include svn_hash.h// seems like a bad idea; we should change it
> _everywhere_ (since other places may grow svn_hash.h includes in the
> future).

Changing the include order such that the semantics of declarations in a
public header depend on whether a private header was included firs is a
bad idea, period.

-- Brane

Branko ─îibej | Director of Subversion
WANdisco // Non-Stop Data

View raw message