subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danie...@apache.org
Subject svn commit: r1502024 - /subversion/trunk/tools/dist/backport.pl
Date Wed, 10 Jul 2013 21:45:20 GMT
Author: danielsh
Date: Wed Jul 10 21:45:19 2013
New Revision: 1502024

URL: http://svn.apache.org/r1502024
Log:
* tools/dist/backport.pl
  (vote): Bail out on unsafe filenames, just like the error message says we do.

Modified:
    subversion/trunk/tools/dist/backport.pl

Modified: subversion/trunk/tools/dist/backport.pl
URL: http://svn.apache.org/viewvc/subversion/trunk/tools/dist/backport.pl?rev=1502024&r1=1502023&r2=1502024&view=diff
==============================================================================
--- subversion/trunk/tools/dist/backport.pl (original)
+++ subversion/trunk/tools/dist/backport.pl Wed Jul 10 21:45:19 2013
@@ -450,8 +450,8 @@ sub vote {
     my ($logmsg_fh, $logmsg_filename) = tempfile();
     print $logmsg_fh $logmsg;
     close $logmsg_fh;
-    warn "Tempfile name '$logmsg_filename' not shell-safe; "
-         ."refraining from commit.\n"
+    warn("Tempfile name '$logmsg_filename' not shell-safe; "
+         ."refraining from commit.\n") and return
         unless $logmsg_filename =~ /^([A-Z0-9._-]|\x2f)+$/i;
     system("$SVN commit -F $logmsg_filename -- $STATUS") == 0
         or warn("Committing the votes failed($?): $!") and return;



Mime
View raw message