subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From 'Daniel Shahaf' <...@daniel.shahaf.name>
Subject Semantics of svn_error_t->apr_err
Date Tue, 09 Jul 2013 20:40:37 GMT
Bert Huijben wrote on Tue, Jul 09, 2013 at 22:32:00 +0200:
> > -----Original Message-----
> > From: Daniel Shahaf [mailto:d.s@daniel.shahaf.name]
> > Bert Huijben wrote on Tue, Jul 09, 2013 at 20:11:57 +0200:
> > > How is this going to help?
> > 
> > I already told you how: it is going to help because API users can't do
> > anything with the value 120171 that they presently receive.  The
> > outermost error must be defined by APR or by Subversion.  120171 is
> > neither.
> 
> *Why* ?
> 
> There is no rule that apr_err must be set to something that is defined by
> APR or Subversion.
> 

I've nothing new to say.  I think every svn_error_t we return from our
APIs should have an APR_ERR member which is either:

- equal to SVN_WARNING;
or
- in some SVN_ERR_CATEGORY_*_START, in the sense defined by
  SVN_ERROR_IN_CATEGORY();
or
- outside the [APR_OS_START_USERERR, APR_OS_START_USERERR+500000]
  range, *and* valid according to APR's concept of validity for
  apr_status_t values outside that range (which in particular means:
  be non-zero).

Can someone please weigh in on this issue?

Mime
View raw message