subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: svn commit: r1501371 - /subversion/trunk/subversion/libsvn_ra_serf/util_error.c
Date Tue, 09 Jul 2013 20:16:19 GMT
Bert Huijben wrote on Tue, Jul 09, 2013 at 20:11:57 +0200:
> Same as for all previous patches in line:
> 

"All previous patches"?  There was one previous patch along these lines.  

> How is this going to help?

I already told you how: it is going to help because API users can't do
anything with the value 120171 that they presently receive.  The
outermost error must be defined by APR or by Subversion.  120171 is
neither.

The impact on users is (a) another error number to search for, (b) the
text "While handling serf response:" in the error message.  That's not
a big change, it's a very small improvement.

Beyond that, I give up.  I've already said everything I have to say.
I *still* haven't heard a valid reason for your veto (can you name an
API consumer whose code would be broken by this?)

And to be honest, I get the impression that you cast a -1 partly because
of what you *assumed* the patch does, even though what it does and what
you assumed it does are not the same thing.

Mime
View raw message