subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <danie...@apache.org>
Subject Re: svn commit: r1488693 - /subversion/trunk/subversion/bindings/swig/perl/native/Client.pm
Date Sun, 07 Jul 2013 13:14:09 GMT
On Sun, Jun 02, 2013 at 12:17:58PM -0000, rschupp@apache.org wrote:
> Author: rschupp
> Date: Sun Jun  2 12:17:58 2013
> New Revision: 1488693
> 
> URL: http://svn.apache.org/r1488693
> Log:
> Documentation and code cleanup changes only.
> 
> * subversion/bindings/swig/perl/native/Client.pm
>   - POD: Add section "ADDITIONAL METHODS" listing all methods wrapped,
>     but not (yet) documented.

+0 to backport this part of the change.

>   - Code: Sort the list @_all_fns.
>   - POD: Use modern sub parameter conventions in POD (no more "shift"ing).

These all non-functional changes.  We don't normally backport such changes
to stable branches, unless needed to prevent text conflicts down the road.

>   - POD: s/$ctx/$client/ which is a more appropriate name for a SVN::Client
>     object.
>   - POD: s/$cinfo/$commit_info/, s/$citem/$commit_item/ 

These mechanical changes make the diff a PITA to review, because (a) it's
now 1000 lines long, (b) it contains all sorts of mechanical changes mixed
in with each other and with functional changes (and with a few
whitespace-only changes that the log message doesn't mention).

I've gone ahead and reviewed it (and I'll cast a +1), but next time please
try and make your commits easier to review.

Cheers,

Daniel

>   - POD: Move =item for "info" into correct spot wrt sorting.

Mime
View raw message