subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <danie...@elego.de>
Subject Re: svn commit: r1499315 - in /subversion/branches/verify-keep-going/subversion: libsvn_repos/dump.c svnadmin/svnadmin.c
Date Wed, 03 Jul 2013 11:37:54 GMT
prabhugs@apache.org wrote on Wed, Jul 03, 2013 at 10:49:02 -0000:
> +  notify_failure->warning_str = apr_psprintf(pool,
> +                                             _("E%06d: %s"),

Would it make sense to push the E%06d: part down to the implementation
of svn_err_best_message()?

I.e., if the information is useful for this caller, presumably it'll be
useful for others too?

> +                                             err->apr_err,
> +                                             svn_err_best_message(err, errbuf,
> +                                                                  sizeof(errbuf)));

Mime
View raw message