subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko ─îibej <br...@wandisco.com>
Subject Re: svn commit: r1463922 - /subversion/trunk/subversion/libsvn_repos/hooks.c
Date Wed, 03 Apr 2013 12:11:03 GMT
On 03.04.2013 13:21, philip@apache.org wrote:
> Author: philip
> Date: Wed Apr  3 11:21:29 2013
> New Revision: 1463922
>
> URL: http://svn.apache.org/r1463922
> Log:
> * subversion/libsvn_repos/hooks.c (parse_hooks_env): Remove unused variable.
>
> Modified:
>     subversion/trunk/subversion/libsvn_repos/hooks.c
>
> Modified: subversion/trunk/subversion/libsvn_repos/hooks.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_repos/hooks.c?rev=1463922&r1=1463921&r2=1463922&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_repos/hooks.c (original)
> +++ subversion/trunk/subversion/libsvn_repos/hooks.c Wed Apr  3 11:21:29 2013
> @@ -418,7 +418,6 @@ parse_hooks_env(apr_hash_t **hooks_env_p
>                  apr_pool_t *scratch_pool)
>  {
>    svn_config_t *cfg;
> -  int n;
>    struct parse_hooks_env_section_baton b;
>  
>    if (local_abspath)
> @@ -426,8 +425,8 @@ parse_hooks_env(apr_hash_t **hooks_env_p
>        SVN_ERR(svn_config_read2(&cfg, local_abspath, FALSE, TRUE, scratch_pool));
>        b.cfg = cfg;
>        b.hooks_env = apr_hash_make(result_pool);
> -      n = svn_config_enumerate_sections2(cfg, parse_hooks_env_section, &b,
> -                                         scratch_pool);
> +      (void)svn_config_enumerate_sections2(cfg, parse_hooks_env_section, &b,
> +                                           scratch_pool);

Ugh yuck. We do not use the void-cast style of telling Lint to not cry
about unused return values. Please remove the cast.

-- Brane


-- 
Branko ─îibej
Director of Subversion | WANdisco | www.wandisco.com


Mime
View raw message