Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@subversion.apache.org
Received-SPF: pass (athena.apache.org: domain of brane@wandisco.com designates
 74.125.83.51 as permitted sender)
Message-ID: <513F991C.9030400@wandisco.com>
Date: Tue, 12 Mar 2013 22:07:40 +0100
From: =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane@wandisco.com>
Organization: WANdisco
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8;
 rv:17.0) Gecko/20130307 Thunderbird/17.0.4
MIME-Version: 1.0
To: commits@subversion.apache.org
Subject: Re: svn commit: r1455645 -
 /subversion/trunk/subversion/bindings/javahl/native/SVNClient.cpp
References: <20130312174352.95C6323888EA@eris.apache.org>
 <061101ce1f64$e3a22c90$aae685b0$@qqmail.nl>
In-Reply-To: <061101ce1f64$e3a22c90$aae685b0$@qqmail.nl>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 12.03.2013 22:02, Bert Huijben wrote:
>
>> -----Original Message-----
>> From: brane@apache.org [mailto:brane@apache.org]
>> Sent: dinsdag 12 maart 2013 18:44
>> To: commits@subversion.apache.org
>> Subject: svn commit: r1455645 -
>> /subversion/trunk/subversion/bindings/javahl/native/SVNClient.cpp
>>
>> Author: brane
>> Date: Tue Mar 12 17:43:52 2013
>> New Revision: 1455645
>>
>> URL: http://svn.apache.org/r1455645
>> Log:
>> Working on isue #4326 (update javahl with new 1.8 APIs).
>>
>> * subversion/bindings/javahl/native/SVNClient.cpp (SVNClient::commit):
>>    Call svn_client_commit6 (with externals drilldown enabled) instead
>>    of svn_client_commit5.
>>
>> Modified:
>>     subversion/trunk/subversion/bindings/javahl/native/SVNClient.cpp
>>
>> Modified:
>> subversion/trunk/subversion/bindings/javahl/native/SVNClient.cpp
>> URL:
>> http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl
>> /native/SVNClient.cpp?rev=1455645&r1=1455644&r2=1455645&view=diff
>> ==========================================================
>> ====================
>> --- subversion/trunk/subversion/bindings/javahl/native/SVNClient.cpp
>> (original)
>> +++ subversion/trunk/subversion/bindings/javahl/native/SVNClient.cpp Tue
>> Mar 12 17:43:52 2013
>> @@ -425,8 +425,9 @@ void SVNClient::commit(Targets &targets,
>>      if (ctx == NULL)
>>          return;
>>
>> -    SVN_JNI_ERR(svn_client_commit5(targets2, depth,
>> -                                   noUnlock, keepChangelist, TRUE,
>> +    SVN_JNI_ERR(svn_client_commit6(targets2, depth,
>> +                                   noUnlock, keepChangelist,
>> +                                   TRUE, TRUE, TRUE,
> This will probably break Subclipse.
>
> The default should be to not go into externals.
>
> Clients like subclipse pass a list of targets and depth empty, while this will just commit every external when committing the root of the wc with depth empty.

That sounds just wrong. With depth=empty, I'd expect /not/ to recurse
into externals, regardless of the value of the include_externals flag.

-- Brane


-- 
Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com