subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache subversion Wiki <comm...@subversion.apache.org>
Subject [Subversion Wiki] Update of "Svn18ApiReview" by CMichaelPilato
Date Fri, 29 Mar 2013 18:32:01 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Subversion Wiki" for change notification.

The "Svn18ApiReview" page has been changed by CMichaelPilato:
http://wiki.apache.org/subversion/Svn18ApiReview?action=diff&rev1=32&rev2=33

Comment:
Reviewed svn_fs.h API additions.

  
  ----
  == Needs Review ==
- 
- === svn_fs.h ===
- New defines:
- 
-  * `#define SVN_FS_CONFIG_FSFS_CACHE_REVPROPS`
-  * `#define SVN_FS_CONFIG_PRE_1_8_COMPATIBLE`
- 
- New types:
- 
-  * `typedef svn_fs_progress_notify_func_t`
-  * `typedef svn_fs_process_contents_func_t`
- 
- New functions:
- 
-  * `svn_fs_verify`
-  * `svn_fs_verify_root`
-  * `svn_fs_hotcopy2`
-  * `svn_fs_freeze`
-  * `svn_fs_get_mergeinfo2`
-  * `svn_fs_try_process_file_contents`
  
  === svn_repos.h ===
  New types:
@@ -143, +123 @@

   * `svn_auth_cleanup_walk` -- I'm really not fond of this API.  Interface-wise, it's very
inconsistent with other svn_auth* interfaces.  The API should allow cleanup even when no-auth-cache
is set in the auth parameter hash, because that flag means "don't cache new auth creds", not
"pretend like I have no auth cache".  If I'm reading it correctly, it will allow orphaned
information to remain in third-party keyring providers while still blowing away the metadata
which gives that information its context within Subversion.  I believe this API needs to be
completely rethought, and I'd prefer to do so post-1.8 where I expect to be continuing the
master passphrase feature. (cmpilato)
   * `svn_auth_get_gpg_agent_simple_provider` -- OK
  
+ === svn_fs.h ===
+ New functions:
+ 
+  * `svn_fs_verify` -- Docstring paragraph describing `@start` and `@end` doesn't parse and
needs to be rewritten for clarification.
+ 
  === svn_ra.h ===
  New functions:
  
@@ -227, +212 @@

   * `SVN_ERR_TOO_MANY_MEMCACHED_SERVERS`
   * `SVN_ERR_MALFORMED_VERSION_STRING`
   * `SVN_ERR_CORRUPTED_ATOMIC_STORAGE`
+ 
+ === svn_fs.h ===
+ New defines:
+ 
+  * `#define SVN_FS_CONFIG_FSFS_CACHE_REVPROPS`
+  * `#define SVN_FS_CONFIG_PRE_1_8_COMPATIBLE`
+ 
+ New types:
+ 
+  * `typedef svn_fs_progress_notify_func_t`
+  * `typedef svn_fs_process_contents_func_t`
+ 
+ New functions:
+ 
+  * `svn_fs_verify_root`
+  * `svn_fs_hotcopy2`
+  * `svn_fs_freeze`
+  * `svn_fs_get_mergeinfo2`
+  * `svn_fs_try_process_file_contents`
  
  === svn_hash.h ===
  New macros:

Mime
View raw message