subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bre...@apache.org
Subject svn commit: r1459599 - /subversion/trunk/subversion/mod_dav_svn/reports/log.c
Date Fri, 22 Mar 2013 00:08:14 GMT
Author: breser
Date: Fri Mar 22 00:08:14 2013
New Revision: 1459599

URL: http://svn.apache.org/r1459599
Log:
Bail out earlier in the case of an error with limit data.

Cleanup bit isn't needed if svn_repos_get_logs4() is never called.

* subversion/mod_dav_svn/reports/log.c
  (dav_svn__log_report): Return immediately on err converting limit cdata to
    int.

Patch by: philip

Modified:
    subversion/trunk/subversion/mod_dav_svn/reports/log.c

Modified: subversion/trunk/subversion/mod_dav_svn/reports/log.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/mod_dav_svn/reports/log.c?rev=1459599&r1=1459598&r2=1459599&view=diff
==============================================================================
--- subversion/trunk/subversion/mod_dav_svn/reports/log.c (original)
+++ subversion/trunk/subversion/mod_dav_svn/reports/log.c Fri Mar 22 00:08:14 2013
@@ -341,10 +341,9 @@ dav_svn__log_report(const dav_resource *
                                   dav_xml_get_cdata(child, resource->pool, 1));
           if (serr)
             {
-              derr = dav_svn__convert_err(serr, HTTP_BAD_REQUEST,
+              return dav_svn__convert_err(serr, HTTP_BAD_REQUEST,
                                           "Malformed CDATA in element "
                                           "\"limit\"", resource->pool);
-              goto cleanup;
             }
         }
       else if (strcmp(child->name, "discover-changed-paths") == 0)



Mime
View raw message