subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhuij...@apache.org
Subject svn commit: r1441189 - /subversion/trunk/subversion/tests/cmdline/upgrade_tests.py
Date Thu, 31 Jan 2013 21:02:17 GMT
Author: rhuijben
Date: Thu Jan 31 21:02:17 2013
New Revision: 1441189

URL: http://svn.apache.org/viewvc?rev=1441189&view=rev
Log:
* subversion/tests/cmdline/upgrade_tests.py
  (upgrade_missing_replaced): Make this test PASS again by disabling the
    entry verification step. This is how it worked through 1.7.

Modified:
    subversion/trunk/subversion/tests/cmdline/upgrade_tests.py

Modified: subversion/trunk/subversion/tests/cmdline/upgrade_tests.py
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/upgrade_tests.py?rev=1441189&r1=1441188&r2=1441189&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/cmdline/upgrade_tests.py (original)
+++ subversion/trunk/subversion/tests/cmdline/upgrade_tests.py Thu Jan 31 21:02:17 2013
@@ -1204,9 +1204,7 @@ def upgrade_file_externals(sbox):
       'alpha' : {'pname3' : 'pvalue3' },
       })
 
-
 @Issue(4035)
-@Wimp('Fails in maintainer mode')
 def upgrade_missing_replaced(sbox):
   "upgrade with missing replaced dir"
 
@@ -1230,12 +1228,19 @@ def upgrade_missing_replaced(sbox):
   expected_status.tweak('A/B/E', status='! ', treeconflict='C', wc_rev='-',
                         entry_status='R ', entry_rev='1')
   expected_status.tweak('A/B/E/alpha', 'A/B/E/beta', status='D ')
+
+  # This upgrade installs an INCOMPLETE node in WORKING for E, which makes the
+  # database technically invalid... but we did that for 1.7 and nobody noticed.
+
+  # Pass the old status tree to avoid testing via entries-dump
+  # as fetching the entries crashes on the invalid db state.
   svntest.actions.run_and_verify_update(sbox.wc_dir, expected_output,
-                                        None, expected_status)
+                                        None, expected_status.old_tree())
 
   svntest.actions.run_and_verify_svn(None, 'Reverted.*', [], 'revert', '-R',
                                      sbox.wc_dir)
   expected_status = svntest.actions.get_virginal_state(sbox.wc_dir, 1)
+  # And verify that the state is now valid in both the entries an status world.
   svntest.actions.run_and_verify_status(sbox.wc_dir, expected_status)
 
 @Issue(4033)



Mime
View raw message