subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From julianf...@apache.org
Subject svn commit: r1423104 - /subversion/trunk/subversion/libsvn_wc/translate.h
Date Mon, 17 Dec 2012 19:29:34 GMT
Author: julianfoad
Date: Mon Dec 17 19:29:33 2012
New Revision: 1423104

URL: http://svn.apache.org/viewvc?rev=1423104&view=rev
Log:
* subversion/libsvn_wc/translate.h
  (svn_wc__expand_keywords): Point out errors in the doc string.

Modified:
    subversion/trunk/subversion/libsvn_wc/translate.h

Modified: subversion/trunk/subversion/libsvn_wc/translate.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/translate.h?rev=1423104&r1=1423103&r2=1423104&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_wc/translate.h (original)
+++ subversion/trunk/subversion/libsvn_wc/translate.h Mon Dec 17 19:29:33 2012
@@ -103,15 +103,21 @@ void svn_wc__eol_value_from_string(const
    If a keyword is in the list, but no corresponding value is
    available, do not create a hash entry for it.  If no keywords are
    found in the list, or if there is no list, set *KEYWORDS to NULL.
+     ### THIS LOOKS WRONG -- it creates a hash entry for every recognized kw
+         and expands each missing value as an empty string or "-1" or similar.
 
    Use LOCAL_ABSPATH to expand keyword values.
 
    If WRI_ABSPATH is not NULL, retrieve the information for LOCAL_ABSPATH
    from the working copy identified by WRI_ABSPATH. Falling back to file
    external information if the file is not present as versioned node.
+     ### THIS IS NOT IMPLEMENTED -- WRI_ABSPATH is ignored
 
    If FOR_NORMALIZATION is TRUE, just return a list of keywords instead of
    calculating their intended values.
+     ### This would be better done by a separate API, since in this case
+         only the KEYWORD_LIST input parameter is needed. (And there is no
+         need to print "-1" as the revision value.)
 
    Use SCRATCH_POOL for any temporary allocations.
 */



Mime
View raw message