Return-Path: X-Original-To: apmail-subversion-commits-archive@minotaur.apache.org Delivered-To: apmail-subversion-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 26960DDF7 for ; Thu, 29 Nov 2012 19:02:08 +0000 (UTC) Received: (qmail 8823 invoked by uid 500); 29 Nov 2012 19:02:08 -0000 Delivered-To: apmail-subversion-commits-archive@subversion.apache.org Received: (qmail 8792 invoked by uid 500); 29 Nov 2012 19:02:08 -0000 Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@subversion.apache.org Delivered-To: mailing list commits@subversion.apache.org Received: (qmail 8785 invoked by uid 99); 29 Nov 2012 19:02:08 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Nov 2012 19:02:07 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Nov 2012 19:02:07 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id E649E2388993; Thu, 29 Nov 2012 19:01:46 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1415323 - /subversion/trunk/subversion/svn/props.c Date: Thu, 29 Nov 2012 19:01:46 -0000 To: commits@subversion.apache.org From: julianfoad@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20121129190146.E649E2388993@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: julianfoad Date: Thu Nov 29 19:01:45 2012 New Revision: 1415323 URL: http://svn.apache.org/viewvc?rev=1415323&view=rev Log: Extend 'svn propset's warning about apparent attempts to set a boolean svn:* property to a value meaning 'off', to catch a few more cases. * subversion/svn/props.c (svn_cl__check_boolean_prop_val): Warn on case-insensitive variants, not just lower case forms of 'no', 'off', 'false'. Also warn on '0'. Modified: subversion/trunk/subversion/svn/props.c Modified: subversion/trunk/subversion/svn/props.c URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/props.c?rev=1415323&r1=1415322&r2=1415323&view=diff ============================================================================== --- subversion/trunk/subversion/svn/props.c (original) +++ subversion/trunk/subversion/svn/props.c Thu Nov 29 19:01:45 2012 @@ -211,9 +211,10 @@ svn_cl__check_boolean_prop_val(const cha svn_stringbuf_strip_whitespace(propbuf); if (propbuf->data[0] == '\0' - || strcmp(propbuf->data, "no") == 0 - || strcmp(propbuf->data, "off") == 0 - || strcmp(propbuf->data, "false") == 0) + || svn_cstring_casecmp(propbuf->data, "0") == 0 + || svn_cstring_casecmp(propbuf->data, "no") == 0 + || svn_cstring_casecmp(propbuf->data, "off") == 0 + || svn_cstring_casecmp(propbuf->data, "false") == 0) { svn_error_t *err = svn_error_createf (SVN_ERR_BAD_PROPERTY_VALUE, NULL,