subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From julianf...@apache.org
Subject svn commit: r1415323 - /subversion/trunk/subversion/svn/props.c
Date Thu, 29 Nov 2012 19:01:46 GMT
Author: julianfoad
Date: Thu Nov 29 19:01:45 2012
New Revision: 1415323

URL: http://svn.apache.org/viewvc?rev=1415323&view=rev
Log:
Extend 'svn propset's warning about apparent attempts to set a boolean svn:*
property to a value meaning 'off', to catch a few more cases.

* subversion/svn/props.c
  (svn_cl__check_boolean_prop_val): Warn on case-insensitive variants, not
    just lower case forms of 'no', 'off', 'false'. Also warn on '0'.

Modified:
    subversion/trunk/subversion/svn/props.c

Modified: subversion/trunk/subversion/svn/props.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/props.c?rev=1415323&r1=1415322&r2=1415323&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/props.c (original)
+++ subversion/trunk/subversion/svn/props.c Thu Nov 29 19:01:45 2012
@@ -211,9 +211,10 @@ svn_cl__check_boolean_prop_val(const cha
   svn_stringbuf_strip_whitespace(propbuf);
 
   if (propbuf->data[0] == '\0'
-      || strcmp(propbuf->data, "no") == 0
-      || strcmp(propbuf->data, "off") == 0
-      || strcmp(propbuf->data, "false") == 0)
+      || svn_cstring_casecmp(propbuf->data, "0") == 0
+      || svn_cstring_casecmp(propbuf->data, "no") == 0
+      || svn_cstring_casecmp(propbuf->data, "off") == 0
+      || svn_cstring_casecmp(propbuf->data, "false") == 0)
     {
       svn_error_t *err = svn_error_createf
         (SVN_ERR_BAD_PROPERTY_VALUE, NULL,



Mime
View raw message