Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@subversion.apache.org
Received-SPF: pass (nike.apache.org: local policy)
Date: Tue, 16 Oct 2012 02:41:57 +0200
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: dev@subversion.apache.org
Cc: commits@subversion.apache.org
Subject: Re: svn commit: r1398541 - /subversion/branches/1.7.x/STATUS
Message-ID: <20121016004157.GB4570@lp-shahaf.local>
References: <20121015222032.768FD23888EA@eris.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20121015222032.768FD23888EA@eris.apache.org>
User-Agent: Mutt/1.5.18 (2008-05-17)

philip@apache.org wrote on Mon, Oct 15, 2012 at 22:20:32 -0000:
> Author: philip
> Date: Mon Oct 15 22:20:32 2012
> New Revision: 1398541
> 
> URL: http://svn.apache.org/viewvc?rev=1398541&view=rev
> Log:
> * STATUS: Clarify effect of r1237779.
> 
> Modified:
>     subversion/branches/1.7.x/STATUS
> 
> Modified: subversion/branches/1.7.x/STATUS
> URL: http://svn.apache.org/viewvc/subversion/branches/1.7.x/STATUS?rev=1398541&r1=1398540&r2=1398541&view=diff
> ==============================================================================
> --- subversion/branches/1.7.x/STATUS (original)
> +++ subversion/branches/1.7.x/STATUS Mon Oct 15 22:20:32 2012
> @@ -71,7 +71,7 @@ Candidate changes:
>       +1: cmpilato
>  
>   * r1237779
> -   Fix sense of property validation on load.
> +   Fix sense of property validation on load and make the revprop change atomic.

The code uses either svn_repos_fs_change_rev_prop4() or
svn_fs_change_rev_prop2().  Both of them support atomic revprop changes,
but for both of them the code passes NULL to disable that functinoality.

IOW, that revision doesn't change atomicity, AFAICT.

>     Justification:
>       Validation is supposed to be on by default but is off, adding
>       --bypass-prop-validation switches it on.
> 
>