subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: svn commit: r1400423 - /subversion/trunk/subversion/libsvn_fs_fs/structure
Date Sun, 21 Oct 2012 20:33:24 GMT
stefan2@apache.org wrote on Sat, Oct 20, 2012 at 11:47:11 -0000:
> Author: stefan2
> Date: Sat Oct 20 11:47:10 2012
> New Revision: 1400423
> 
> URL: http://svn.apache.org/viewvc?rev=1400423&view=rev
> Log:
> * subversion/libsvn_fs_fs/structure
>   (Packing revision properties): add short description of the svndiff
>    integer format
> 
> Modified:
>     subversion/trunk/subversion/libsvn_fs_fs/structure
> 
> Modified: subversion/trunk/subversion/libsvn_fs_fs/structure
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/structure?rev=1400423&r1=1400422&r2=1400423&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_fs_fs/structure (original)
> +++ subversion/trunk/subversion/libsvn_fs_fs/structure Sat Oct 20 11:47:10 2012
> @@ -277,8 +277,10 @@ Pack file format
>  
>    We always apply data compression to the pack file - using the
>    SVN_DELTA_COMPRESSION_LEVEL_NONE level if compression is disabled.
> -  <length> is being encoded using the variable-length svndiff integer
> -  format.
> +  <length> is being encoded using the variable-length svndiff unsigned
> +  integer format (see svndiff.c): 7 bits / byte in little endian order
> +  with the MSB of each byte indicating whether there is a another byte
> +  to read.

Per the other thread, I think this would be more appropriate:

Index: structure
===================================================================
--- structure   (revision 1400717)
+++ structure   (working copy)
@@ -273,14 +273,12 @@
 
 Pack file format
 
-  Top level: <length><packed container>
+  Top level: <packed container>
 
   We always apply data compression to the pack file - using the
   SVN_DELTA_COMPRESSION_LEVEL_NONE level if compression is disabled.
-  <length> is being encoded using the variable-length svndiff unsigned
-  integer format (see svndiff.c): 7 bits / byte in little endian order
-  with the MSB of each byte indicating whether there is a another byte
-  to read.
+  (Note that compression at SVN_DELTA_COMPRESSION_LEVEL_NONE is not
+  a no-op stream transformation.)
 
   container := header '\n' (revprops)+
   header    := start_rev '\n' rev_count '\n' (size '\n')+

and leave the details of the non-no-op transformation to the
documentation of svn__compress().

WDYT


Mime
View raw message