subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: svn commit: r1382990 - in /subversion/trunk/subversion: include/ libsvn_subr/ tests/cmdline/ tests/cmdline/getopt_tests_data/
Date Mon, 10 Sep 2012 21:49:22 GMT
brane@apache.org wrote on Mon, Sep 10, 2012 at 17:19:32 -0000:
> Author: brane
> Date: Mon Sep 10 17:19:31 2012
> New Revision: 1382990
> 
> URL: http://svn.apache.org/viewvc?rev=1382990&view=rev
> Log:
> Make the extended version info retrieval a public API.
> 
> +/**
> + * Extended version infomation, including info about the running system.
> + *
> + * @since New in 1.8.
> + */

Are we going to extend the struct in future releases?  If so, do we want
constructor/duplicator functions?

> +typedef struct svn_version_extended_t
> +{
> +  const char *version_number;   /**< Version number */
> +  const char *version_string;   /**< Version string */
> +  const char *build_date;       /**< Compilation date */
> +  const char *build_time;       /**< Compilation time */
> +  const char *build_host;       /**< Build canonical host name */
> +  const char *copyright;        /**< Copyright notice (localized) */
> +  const char *runtime_host;     /**< Runtime canonical host name */
> +  const char *runtime_osname;   /**< Running OS release name */
> +
> +  /**
> +   * Array svn_version_linked_lib_t describing dependent libraries.
> +   */
> +  const apr_array_header_t *linked_libs;
> +
> +  /**
> +   * Array of svn_version_loaded_lib_t describing loaded shared libraries.
> +   */
> +  const apr_array_header_t *loaded_libs;

Please document the type ('const char *' ? ) of array elements.

> +} svn_version_extended_t;

Cheers,

Daniel


Mime
View raw message