Return-Path: X-Original-To: apmail-subversion-commits-archive@minotaur.apache.org Delivered-To: apmail-subversion-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9709CD54A for ; Fri, 24 Aug 2012 17:03:09 +0000 (UTC) Received: (qmail 22275 invoked by uid 500); 24 Aug 2012 17:03:09 -0000 Delivered-To: apmail-subversion-commits-archive@subversion.apache.org Received: (qmail 22228 invoked by uid 500); 24 Aug 2012 17:03:09 -0000 Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@subversion.apache.org Delivered-To: mailing list commits@subversion.apache.org Received: (qmail 22220 invoked by uid 99); 24 Aug 2012 17:03:09 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Aug 2012 17:03:09 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Aug 2012 17:03:08 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 44AA72388962; Fri, 24 Aug 2012 17:02:25 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1376992 - /subversion/trunk/subversion/libsvn_repos/repos.c Date: Fri, 24 Aug 2012 17:02:25 -0000 To: commits@subversion.apache.org From: cmpilato@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120824170225.44AA72388962@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: cmpilato Date: Fri Aug 24 17:02:24 2012 New Revision: 1376992 URL: http://svn.apache.org/viewvc?rev=1376992&view=rev Log: * subversion/libsvn_repos/repos.c (create_hooks): Tweak 'start-commit' template text, grouping the description of the TXN-NAME arg closer to that of the CAPABILITIES arg. Modified: subversion/trunk/subversion/libsvn_repos/repos.c Modified: subversion/trunk/subversion/libsvn_repos/repos.c URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_repos/repos.c?rev=1376992&r1=1376991&r2=1376992&view=diff ============================================================================== --- subversion/trunk/subversion/libsvn_repos/repos.c (original) +++ subversion/trunk/subversion/libsvn_repos/repos.c Fri Aug 24 17:02:24 2012 @@ -330,6 +330,11 @@ create_hooks(svn_repos_t *repos, apr_poo "# e.g.: \"" SVN_RA_CAPABILITY_MERGEINFO ":some-other-capability\" " \ "(the order is undefined)." NL "#" NL +"# Note: The TXN-NAME parameter is new in Subversion 1.8. Prior to version" NL +"# 1.8, the start-commit hook was invoked before the commit txn was even" NL +"# created, so the ability to inspect the commit txn and its metadata from" NL +"# within the start-commit hook was not possible." NL +"# " NL "# The list is self-reported by the client. Therefore, you should not" NL "# make security assumptions based on the capabilities list, nor should" NL "# you assume that clients reliably report every capability they have." NL @@ -353,10 +358,6 @@ create_hooks(svn_repos_t *repos, apr_poo "# '"SCRIPT_NAME".bat' or '"SCRIPT_NAME".exe'," NL "# but the basic idea is the same." NL "# " NL -"# COMPATIBILITY NOTE: Prior to Subversion 1.8, the start-commit hook was" NL -"# invoked before the commit txn was even created, and it did not accept" NL -"# the TXN-NAME argument at all." NL -"# " NL HOOKS_ENVIRONMENT_TEXT "# " NL "# Here is an example hook script, for a Unix /bin/sh interpreter." NL