subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: svn commit: r1367683 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c
Date Mon, 13 Aug 2012 07:30:39 GMT
philip@apache.org wrote on Tue, Jul 31, 2012 at 17:14:58 -0000:
> Author: philip
> Date: Tue Jul 31 17:14:58 2012
> New Revision: 1367683
> 
> URL: http://svn.apache.org/viewvc?rev=1367683&view=rev
> Log:
> Fix issue 4213, "svnadmin recover" fails on old format repositories.
> 
> * subversion/libsvn_fs_fs/fs_fs.c
>   (open_pack_or_rev_file): Return SVN_ERR_FS_NO_SUCH_REVISION for
>    old format repositories.


Worth a regression test?

Index: subversion/tests/cmdline/svnadmin_tests.py
===================================================================
--- subversion/tests/cmdline/svnadmin_tests.py	(revision 1372130)
+++ subversion/tests/cmdline/svnadmin_tests.py	(working copy)
@@ -1821,6 +1821,11 @@ def mergeinfo_race(sbox):
     raise svntest.Failure("one or both commits failed")
 
 
+@Issue(4213)
+def recover_old(sbox):
+  "recover --pre-1.4-compatible"
+  sbox.build(create_wc=False)
+  svntest.main.run_svnadmin("recover", sbox.repo_dir)
 
 
 ########################################################################
@@ -1858,6 +1863,7 @@ test_list = [ None,
               hotcopy_incremental_packed,
               locking,
               mergeinfo_race,
+              recover_old,
              ]
 
 if __name__ == '__main__':

Mime
View raw message