Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@subversion.apache.org
Received-SPF: pass (nike.apache.org: domain of hyrum.wright@wandisco.com
 designates 209.85.212.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <20120613161025.9141D2388A33@eris.apache.org>
References: <20120613161025.9141D2388A33@eris.apache.org>
Date: Wed, 13 Jun 2012 19:36:24 +0200
Message-ID: 
 <CAJjMeYNh+uy4nOUiiq8snb=CHLVNudY3GS47JdqEkCgNY3_THA@mail.gmail.com>
Subject: Re: svn commit: r1349944 - /subversion/trunk/gen-make.py
From: Hyrum K Wright <hyrum.wright@wandisco.com>
To: dev@subversion.apache.org
Cc: commits@subversion.apache.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 13, 2012 at 6:10 PM,  <rhuijben@apache.org> wrote:
> Author: rhuijben
> Date: Wed Jun 13 16:10:25 2012
> New Revision: 1349944
>
> URL: http://svn.apache.org/viewvc?rev=3D1349944&view=3Drev
> Log:
> * gen-make.py
> =C2=A0Make the --with-neon=3D and --without-neon arguments on gen-make.py=
 optional,
> =C2=A0just like how ./configure handles those. Windows doesn't use ./conf=
igure and
> =C2=A0this breaks tools that are friendly enough to provide hints.

I don't like this change.  ./configure *doesn't* work this way: it
errors when attempting to provide the now-defunct neon options.

Neon is gone, dead, buried.  We shouldn't be special casing it in this
manner: people who rely on neon will have more work to do than just
updating their scripts, and we don't need to coddle them along the
way.

-Hyrum

>
> Modified:
> =C2=A0 =C2=A0subversion/trunk/gen-make.py
>
> Modified: subversion/trunk/gen-make.py
> URL: http://svn.apache.org/viewvc/subversion/trunk/gen-make.py?rev=3D1349=
944&r1=3D1349943&r2=3D1349944&view=3Ddiff
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- subversion/trunk/gen-make.py (original)
> +++ subversion/trunk/gen-make.py Wed Jun 13 16:10:25 2012
> @@ -257,6 +257,13 @@ if __name__ =3D=3D '__main__':
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 'disable-shared',
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 'installed-libs=3D',
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 'vsnet-version=3D',
> +
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0# Keep distributions that help by adding a path
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0# working. On unix this would be filtered by
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0# configure, but on Windows gen-make.py is used
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0# directly.
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0'with-neon=3D',
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0'without-neon',
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 ])
> =C2=A0 =C2=A0 if len(args) > 1:
> =C2=A0 =C2=A0 =C2=A0 _usage_exit("Too many arguments")
> @@ -281,6 +288,9 @@ if __name__ =3D=3D '__main__':
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 if opt !=3D '--debug':
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 rest.add(opt, val)
> =C2=A0 =C2=A0 =C2=A0 del prev_conf
> + =C2=A0 =C2=A0elif opt =3D=3D '--with-neon' or opt =3D=3D '--without-neo=
n':
> + =C2=A0 =C2=A0 =C2=A0# Provide a warning that we ignored these arguments
> + =C2=A0 =C2=A0 =C2=A0print("Ignoring no longer supported argument '%s'" =
% opt)
> =C2=A0 =C2=A0 else:
> =C2=A0 =C2=A0 =C2=A0 rest.add(opt, val)
>
>
>


--=20

uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/