subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gst...@apache.org
Subject svn commit: r1334690 - in /subversion/trunk/subversion/libsvn_ra_serf: getdate.c getlocks.c locks.c replay.c update.c
Date Sun, 06 May 2012 16:46:53 GMT
Author: gstein
Date: Sun May  6 16:46:52 2012
New Revision: 1334690

URL: http://svn.apache.org/viewvc?rev=1334690&view=rev
Log:
Leave markers where we have not set HANDLER_POOL. We may want to make
it mandatory in the future.

* subversion/libsvn_ra_serf/replay.c:
* subversion/libsvn_ra_serf/getlocks.c:
* subversion/libsvn_ra_serf/getdate.c:
* subversion/libsvn_ra_serf/locks.c:
* subversion/libsvn_ra_serf/update.c:
  (...): leave markers where we do not initialize HANDLER_POOL

Modified:
    subversion/trunk/subversion/libsvn_ra_serf/getdate.c
    subversion/trunk/subversion/libsvn_ra_serf/getlocks.c
    subversion/trunk/subversion/libsvn_ra_serf/locks.c
    subversion/trunk/subversion/libsvn_ra_serf/replay.c
    subversion/trunk/subversion/libsvn_ra_serf/update.c

Modified: subversion/trunk/subversion/libsvn_ra_serf/getdate.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/getdate.c?rev=1334690&r1=1334689&r2=1334690&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/getdate.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/getdate.c Sun May  6 16:46:52 2012
@@ -181,6 +181,7 @@ svn_ra_serf__get_dated_revision(svn_ra_s
 
   handler = apr_pcalloc(pool, sizeof(*handler));
 
+  /* ### skip setting HANDLER_POOL?  */
   handler->method = "REPORT";
   handler->path = report_target;
   handler->body_type = "text/xml";

Modified: subversion/trunk/subversion/libsvn_ra_serf/getlocks.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/getlocks.c?rev=1334690&r1=1334689&r2=1334690&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/getlocks.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/getlocks.c Sun May  6 16:46:52 2012
@@ -340,6 +340,7 @@ svn_ra_serf__get_locks(svn_ra_session_t 
 
   handler = apr_pcalloc(pool, sizeof(*handler));
 
+  /* ### skip setting HANDLER_POOL?  */
   handler->method = "REPORT";
   handler->path = req_url;
   handler->body_type = "text/xml";

Modified: subversion/trunk/subversion/libsvn_ra_serf/locks.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/locks.c?rev=1334690&r1=1334689&r2=1334690&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/locks.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/locks.c Sun May  6 16:46:52 2012
@@ -591,6 +591,7 @@ svn_ra_serf__lock(svn_ra_session_t *ra_s
 
       handler = apr_pcalloc(iterpool, sizeof(*handler));
 
+      /* ### skip setting HANDLER_POOL?  */
       handler->method = "LOCK";
       handler->path = req_url;
       handler->body_type = "text/xml";

Modified: subversion/trunk/subversion/libsvn_ra_serf/replay.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/replay.c?rev=1334690&r1=1334689&r2=1334690&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/replay.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/replay.c Sun May  6 16:46:52 2012
@@ -659,6 +659,7 @@ svn_ra_serf__replay(svn_ra_session_t *ra
 
   handler = apr_pcalloc(pool, sizeof(*handler));
 
+  /* ### skip setting HANDLER_POOL?  */
   handler->method = "REPORT";
   handler->path = session->session_url_str;
   handler->body_delegate = create_replay_body;
@@ -797,6 +798,7 @@ svn_ra_serf__replay_range(svn_ra_session
           /* Send the replay report request. */
           handler = apr_pcalloc(replay_ctx->src_rev_pool, sizeof(*handler));
 
+          /* ### skip setting HANDLER_POOL?  */
           handler->method = "REPORT";
           handler->path = session->session_url_str;
           handler->body_delegate = create_replay_body;

Modified: subversion/trunk/subversion/libsvn_ra_serf/update.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/update.c?rev=1334690&r1=1334689&r2=1334690&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/update.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/update.c Sun May  6 16:46:52 2012
@@ -1493,6 +1493,7 @@ fetch_file(report_context_t *ctx, report
 
           handler = apr_pcalloc(info->dir->pool, sizeof(*handler));
 
+          /* ### skip setting HANDLER_POOL?  */
           handler->method = "HEAD";
           handler->path = fetch_ctx->info->url;
 
@@ -1518,6 +1519,7 @@ fetch_file(report_context_t *ctx, report
 
           handler = apr_pcalloc(info->dir->pool, sizeof(*handler));
 
+          /* ### skip setting HANDLER_POOL?  */
           handler->method = "GET";
           handler->path = fetch_ctx->info->url;
 
@@ -2564,6 +2566,7 @@ finish_report(void *report_baton,
 
   handler = apr_pcalloc(pool, sizeof(*handler));
 
+  /* ### skip setting HANDLER_POOL?  */
   handler->method = "REPORT";
   handler->path = report->path;
   handler->body_delegate = create_update_report_body;
@@ -3084,6 +3087,8 @@ svn_ra_serf__get_file(svn_ra_session_t *
       stream_ctx->info->name = fetch_url;
 
       handler = apr_pcalloc(pool, sizeof(*handler));
+
+      /* ### skip setting HANDLER_POOL?  */
       handler->method = "GET";
       handler->path = fetch_url;
       handler->conn = conn;



Mime
View raw message