subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gst...@apache.org
Subject svn commit: r1334446 - in /subversion/trunk/subversion/libsvn_ra_serf: blame.c get_deleted_rev.c getdate.c getlocations.c getlocationsegments.c getlocks.c locks.c log.c mergeinfo.c ra_serf.h replay.c update.c util.c
Date Sat, 05 May 2012 16:42:11 GMT
Author: gstein
Date: Sat May  5 16:42:10 2012
New Revision: 1334446

URL: http://svn.apache.org/viewvc?rev=1334446&view=rev
Log:
Switch many request handlers to use HANDLER->SLINE.CODE rather than
the STATUS_CODE produced by the XML parsing (which was the wrong level
of abstraction).

Some handlers just don't use the status code, so it was removed. Those
that need it fill in a HANDLER_POOL to get the correct data from the
response header.

* subversion/libsvn_ra_serf/ra_serf.h:
  (svn_ra_serf__handler_t): clarify that HANDLER_POOL must be non-NULL
    to get SLINE and LOCATION filled in.

* subversion/libsvn_ra_serf/getlocationsegments.c:
  (gls_context_t): remove STATUS_CODE
  (svn_ra_serf__get_location_segments): switch to SLINE.CODE

* subversion/libsvn_ra_serf/blame.c:
  (svn_ra_serf__get_file_revs): switch to SLINE.CODE

* subversion/libsvn_ra_serf/log.c:
  (log_context_t): remove STATUS_CODE
  (svn_ra_serf__get_log): switch to SLINE.CODE

* subversion/libsvn_ra_serf/get_deleted_rev.c:
  (svn_ra_serf__get_deleted_rev): switch to SLINE.CODE

* subversion/libsvn_ra_serf/getlocations.c:
  (loc_context_t): remove STATUS_CODE
  (svn_ra_serf__get_locations): switch to SLINE.CODE

* subversion/libsvn_ra_serf/locks.c:
  (handle_lock): leave a todo for switch to HANDLER->SLINE
  (svn_ra_serf__get_lock): switch to SLINE.CODE

* subversion/libsvn_ra_serf/update.c:
  (finish_report): remove unused STATUS_CODE handling

* subversion/libsvn_ra_serf/replay.c:
  (svn_ra_serf__replya): remove unused STATUS_CODE handling

* subversion/libsvn_ra_serf/mergeinfo.c:
  (svn_ra_serf__get_mergeinfo): remove unused STATUS_CODE handling

* subversion/libsvn_ra_serf/getlocks.c:
  (svn_ra_serf__get_locks): remove unused STATUS_CODE handling

* subversion/libsvn_ra_serf/getdate.c:
  (svn_ra_serf__get_dated_revision): remove unused STATUS_CODE handling

* subversion/libsvn_ra_serf/util.c:
  (svn_ra_serf__handle_xml_parser): use #if to remove an assertion.
    further work to switch to HANDLER->SLINE.

Modified:
    subversion/trunk/subversion/libsvn_ra_serf/blame.c
    subversion/trunk/subversion/libsvn_ra_serf/get_deleted_rev.c
    subversion/trunk/subversion/libsvn_ra_serf/getdate.c
    subversion/trunk/subversion/libsvn_ra_serf/getlocations.c
    subversion/trunk/subversion/libsvn_ra_serf/getlocationsegments.c
    subversion/trunk/subversion/libsvn_ra_serf/getlocks.c
    subversion/trunk/subversion/libsvn_ra_serf/locks.c
    subversion/trunk/subversion/libsvn_ra_serf/log.c
    subversion/trunk/subversion/libsvn_ra_serf/mergeinfo.c
    subversion/trunk/subversion/libsvn_ra_serf/ra_serf.h
    subversion/trunk/subversion/libsvn_ra_serf/replay.c
    subversion/trunk/subversion/libsvn_ra_serf/update.c
    subversion/trunk/subversion/libsvn_ra_serf/util.c

Modified: subversion/trunk/subversion/libsvn_ra_serf/blame.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/blame.c?rev=1334446&r1=1334445&r2=1334446&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/blame.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/blame.c Sat May  5 16:42:10 2012
@@ -428,7 +428,6 @@ svn_ra_serf__get_file_revs(svn_ra_sessio
   svn_ra_serf__handler_t *handler;
   svn_ra_serf__xml_parser_t *parser_ctx;
   const char *relative_url, *basecoll_url, *req_url;
-  int status_code;
   svn_error_t *err;
 
   blame_ctx = apr_pcalloc(pool, sizeof(*blame_ctx));
@@ -448,6 +447,7 @@ svn_ra_serf__get_file_revs(svn_ra_sessio
 
   handler = apr_pcalloc(pool, sizeof(*handler));
 
+  handler->handler_pool = pool;
   handler->method = "REPORT";
   handler->path = req_url;
   handler->body_type = "text/xml";
@@ -464,7 +464,6 @@ svn_ra_serf__get_file_revs(svn_ra_sessio
   parser_ctx->end = end_blame;
   parser_ctx->cdata = cdata_blame;
   parser_ctx->done = &blame_ctx->done;
-  parser_ctx->status_code = &status_code;
 
   handler->response_handler = svn_ra_serf__handle_xml_parser;
   handler->response_baton = parser_ctx;
@@ -474,7 +473,7 @@ svn_ra_serf__get_file_revs(svn_ra_sessio
   err = svn_ra_serf__context_run_wait(&blame_ctx->done, session, pool);
 
   err = svn_error_compose_create(
-            svn_ra_serf__error_on_status(status_code,
+            svn_ra_serf__error_on_status(handler->sline.code,
                                          handler->path,
                                          parser_ctx->location),
             err);

Modified: subversion/trunk/subversion/libsvn_ra_serf/get_deleted_rev.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/get_deleted_rev.c?rev=1334446&r1=1334445&r2=1334446&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/get_deleted_rev.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/get_deleted_rev.c Sat May  5 16:42:10 2012
@@ -188,7 +188,6 @@ svn_ra_serf__get_deleted_rev(svn_ra_sess
   svn_ra_serf__handler_t *handler;
   svn_ra_serf__xml_parser_t *parser_ctx;
   const char *relative_url, *basecoll_url, *req_url;
-  int status_code = 0;
   svn_error_t *err;
 
   drev_ctx = apr_pcalloc(pool, sizeof(*drev_ctx));
@@ -212,9 +211,9 @@ svn_ra_serf__get_deleted_rev(svn_ra_sess
   parser_ctx->end = end_getdrev;
   parser_ctx->cdata = cdata_getdrev;
   parser_ctx->done = &drev_ctx->done;
-  parser_ctx->status_code = &status_code;
 
   handler = apr_pcalloc(pool, sizeof(*handler));
+  handler->handler_pool = pool;
   handler->method = "REPORT";
   handler->path = req_url;
   handler->body_type = "text/xml";
@@ -231,9 +230,10 @@ svn_ra_serf__get_deleted_rev(svn_ra_sess
 
   /* Map status 501: Method Not Implemented to our not implemented error.
      1.5.x servers and older don't support this report. */
-  if (status_code == 501)
+  if (handler->sline.code == 501)
     return svn_error_createf(SVN_ERR_RA_NOT_IMPLEMENTED, err,
-                             _("'%s' REPORT not implemented"), "get-deleted-rev");
+                             _("'%s' REPORT not implemented"),
+                             "get-deleted-rev");
   SVN_ERR(err);
   return SVN_NO_ERROR;
 }

Modified: subversion/trunk/subversion/libsvn_ra_serf/getdate.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/getdate.c?rev=1334446&r1=1334445&r2=1334446&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/getdate.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/getdate.c Sat May  5 16:42:10 2012
@@ -171,7 +171,6 @@ svn_ra_serf__get_dated_revision(svn_ra_s
   svn_ra_serf__handler_t *handler;
   svn_ra_serf__xml_parser_t *parser_ctx;
   const char *report_target;
-  int status_code;
 
   date_ctx = apr_palloc(pool, sizeof(*date_ctx));
   date_ctx->time = tm;
@@ -196,7 +195,6 @@ svn_ra_serf__get_dated_revision(svn_ra_s
   parser_ctx->end = end_getdate;
   parser_ctx->cdata = cdata_getdate;
   parser_ctx->done = &date_ctx->done;
-  parser_ctx->status_code = &status_code;
 
   handler->body_delegate = create_getdate_body;
   handler->body_delegate_baton = date_ctx;
@@ -208,5 +206,7 @@ svn_ra_serf__get_dated_revision(svn_ra_s
 
   *date_ctx->revision = SVN_INVALID_REVNUM;
 
+  /* ### use svn_ra_serf__error_on_status() ?  */
+
   return svn_ra_serf__context_run_wait(&date_ctx->done, session, pool);
 }

Modified: subversion/trunk/subversion/libsvn_ra_serf/getlocations.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/getlocations.c?rev=1334446&r1=1334445&r2=1334446&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/getlocations.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/getlocations.c Sat May  5 16:42:10 2012
@@ -70,8 +70,6 @@ typedef struct loc_context_t {
   loc_state_list_t *state;
   loc_state_list_t *free_state;
 
-  int status_code;
-
   svn_boolean_t done;
 } loc_context_t;
 
@@ -250,6 +248,7 @@ svn_ra_serf__get_locations(svn_ra_sessio
 
   handler = apr_pcalloc(pool, sizeof(*handler));
 
+  handler->handler_pool = pool;
   handler->method = "REPORT";
   handler->path = req_url;
   handler->body_delegate = create_get_locations_body;
@@ -264,7 +263,6 @@ svn_ra_serf__get_locations(svn_ra_sessio
   parser_ctx->user_data = loc_ctx;
   parser_ctx->start = start_getloc;
   parser_ctx->end = end_getloc;
-  parser_ctx->status_code = &loc_ctx->status_code;
   parser_ctx->done = &loc_ctx->done;
 
   handler->response_handler = svn_ra_serf__handle_xml_parser;
@@ -275,7 +273,7 @@ svn_ra_serf__get_locations(svn_ra_sessio
   err = svn_ra_serf__context_run_wait(&loc_ctx->done, session, pool);
 
   SVN_ERR(svn_error_compose_create(
-              svn_ra_serf__error_on_status(loc_ctx->status_code,
+              svn_ra_serf__error_on_status(handler->sline.code,
                                            req_url,
                                            parser_ctx->location),
               err));

Modified: subversion/trunk/subversion/libsvn_ra_serf/getlocationsegments.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/getlocationsegments.c?rev=1334446&r1=1334445&r2=1334446&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/getlocationsegments.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/getlocationsegments.c Sat May  5 16:42:10 2012
@@ -56,8 +56,6 @@ typedef struct gls_context_t {
   /* True iff we're looking at a child of the outer report tag */
   svn_boolean_t inside_report;
 
-  int status_code;
-
   svn_boolean_t done;
 } gls_context_t;
 
@@ -204,6 +202,7 @@ svn_ra_serf__get_location_segments(svn_r
 
   handler = apr_pcalloc(pool, sizeof(*handler));
 
+  handler->handler_pool = pool;
   handler->method = "REPORT";
   handler->path = req_url;
   handler->body_delegate = create_gls_body;
@@ -218,7 +217,6 @@ svn_ra_serf__get_location_segments(svn_r
   parser_ctx->user_data = gls_ctx;
   parser_ctx->start = start_gls;
   parser_ctx->end = end_gls;
-  parser_ctx->status_code = &gls_ctx->status_code;
   parser_ctx->done = &gls_ctx->done;
 
   handler->response_handler = svn_ra_serf__handle_xml_parser;
@@ -234,10 +232,10 @@ svn_ra_serf__get_location_segments(svn_r
                               path, peg_revision);
 
   err = svn_error_compose_create(
-         svn_ra_serf__error_on_status(gls_ctx->status_code,
+         svn_ra_serf__error_on_status(handler->sline.code,
                                       handler->path,
                                       parser_ctx->location),
-         err);;
+         err);
 
   svn_pool_destroy(gls_ctx->subpool);
 

Modified: subversion/trunk/subversion/libsvn_ra_serf/getlocks.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/getlocks.c?rev=1334446&r1=1334445&r2=1334446&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/getlocks.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/getlocks.c Sat May  5 16:42:10 2012
@@ -326,7 +326,6 @@ svn_ra_serf__get_locks(svn_ra_session_t 
   svn_ra_serf__handler_t *handler;
   svn_ra_serf__xml_parser_t *parser_ctx;
   const char *req_url, *rel_path;
-  int status_code;
 
   req_url = svn_path_url_add_component2(session->session_url.path, path, pool);
   SVN_ERR(svn_ra_serf__get_relative_path(&rel_path, req_url, session,
@@ -355,7 +354,6 @@ svn_ra_serf__get_locks(svn_ra_session_t 
   parser_ctx->end = end_getlocks;
   parser_ctx->cdata = cdata_getlocks;
   parser_ctx->done = &lock_ctx->done;
-  parser_ctx->status_code = &status_code;
 
   handler->body_delegate = create_getlocks_body;
   handler->body_delegate_baton = lock_ctx;
@@ -365,6 +363,8 @@ svn_ra_serf__get_locks(svn_ra_session_t 
 
   svn_ra_serf__request_create(handler);
 
+  /* ### use svn_ra_serf__error_on_status() ?  */
+
   SVN_ERR(svn_ra_serf__context_run_wait(&lock_ctx->done, session, pool));
 
   *locks = lock_ctx->hash;

Modified: subversion/trunk/subversion/libsvn_ra_serf/locks.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/locks.c?rev=1334446&r1=1334445&r2=1334446&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/locks.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/locks.c Sat May  5 16:42:10 2012
@@ -358,6 +358,7 @@ handle_lock(serf_request_t *request,
           return svn_error_wrap_apr(status, NULL);
         }
 
+      /* ### get the handler_t in here somehow, and use SLINE.  */
       ctx->status_code = sl.code;
       ctx->reason = sl.reason;
 
@@ -499,7 +500,6 @@ svn_ra_serf__get_lock(svn_ra_session_t *
   lock_info_t *lock_ctx;
   const char *req_url;
   svn_error_t *err;
-  int status_code;
 
   req_url = svn_path_url_add_component2(session->session_url.path, path, pool);
 
@@ -512,6 +512,7 @@ svn_ra_serf__get_lock(svn_ra_session_t *
 
   handler = apr_pcalloc(pool, sizeof(*handler));
 
+  handler->handler_pool = pool;
   handler->method = "PROPFIND";
   handler->path = req_url;
   handler->body_type = "text/xml";
@@ -526,7 +527,6 @@ svn_ra_serf__get_lock(svn_ra_session_t *
   parser_ctx->end = end_lock;
   parser_ctx->cdata = cdata_lock;
   parser_ctx->done = &lock_ctx->done;
-  parser_ctx->status_code = &status_code;
 
   handler->body_delegate = create_getlock_body;
   handler->body_delegate_baton = lock_ctx;
@@ -540,7 +540,7 @@ svn_ra_serf__get_lock(svn_ra_session_t *
   svn_ra_serf__request_create(handler);
   err = svn_ra_serf__context_run_wait(&lock_ctx->done, session, pool);
 
-  if (status_code == 404)
+  if (handler->sline.code == 404)
     {
       return svn_error_create(SVN_ERR_RA_ILLEGAL_URL, err,
                               _("Malformed URL for repository"));

Modified: subversion/trunk/subversion/libsvn_ra_serf/log.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/log.c?rev=1334446&r1=1334445&r2=1334446&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/log.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/log.c Sat May  5 16:42:10 2012
@@ -102,7 +102,6 @@ typedef struct log_context_t {
 
   /* are we done? */
   svn_boolean_t done;
-  int status_code;
 
   /* log receiver function and baton */
   svn_log_entry_receiver_t receiver;
@@ -702,6 +701,7 @@ svn_ra_serf__get_log(svn_ra_session_t *r
 
   handler = apr_pcalloc(pool, sizeof(*handler));
 
+  handler->handler_pool = pool;
   handler->method = "REPORT";
   handler->path = req_url;
   handler->body_delegate = create_log_body;
@@ -718,7 +718,6 @@ svn_ra_serf__get_log(svn_ra_session_t *r
   parser_ctx->end = end_log;
   parser_ctx->cdata = cdata_log;
   parser_ctx->done = &log_ctx->done;
-  parser_ctx->status_code = &log_ctx->status_code;
 
   handler->response_handler = svn_ra_serf__handle_xml_parser;
   handler->response_baton = parser_ctx;
@@ -728,7 +727,7 @@ svn_ra_serf__get_log(svn_ra_session_t *r
   err = svn_ra_serf__context_run_wait(&log_ctx->done, session, pool);
 
   SVN_ERR(svn_error_compose_create(
-              svn_ra_serf__error_on_status(log_ctx->status_code,
+              svn_ra_serf__error_on_status(handler->sline.code,
                                            req_url,
                                            parser_ctx->location),
               err));

Modified: subversion/trunk/subversion/libsvn_ra_serf/mergeinfo.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/mergeinfo.c?rev=1334446&r1=1334445&r2=1334446&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/mergeinfo.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/mergeinfo.c Sat May  5 16:42:10 2012
@@ -241,8 +241,6 @@ svn_ra_serf__get_mergeinfo(svn_ra_sessio
                            apr_pool_t *pool)
 {
   svn_error_t *err, *err2;
-  int status_code;
-
   mergeinfo_context_t *mergeinfo_ctx;
   svn_ra_serf__session_t *session = ra_session->priv;
   svn_ra_serf__handler_t *handler;
@@ -270,6 +268,7 @@ svn_ra_serf__get_mergeinfo(svn_ra_sessio
 
   handler = apr_pcalloc(pool, sizeof(*handler));
 
+  handler->handler_pool = pool;
   handler->method = "REPORT";
   handler->path = path;
   handler->conn = session->conns[0];
@@ -286,7 +285,6 @@ svn_ra_serf__get_mergeinfo(svn_ra_sessio
   parser_ctx->end = end_element;
   parser_ctx->cdata = cdata_handler;
   parser_ctx->done = &mergeinfo_ctx->done;
-  parser_ctx->status_code = &status_code;
 
   handler->response_handler = svn_ra_serf__handle_xml_parser;
   handler->response_baton = parser_ctx;
@@ -295,7 +293,7 @@ svn_ra_serf__get_mergeinfo(svn_ra_sessio
 
   err = svn_ra_serf__context_run_wait(&mergeinfo_ctx->done, session, pool);
 
-  err2 = svn_ra_serf__error_on_status(status_code, handler->path,
+  err2 = svn_ra_serf__error_on_status(handler->sline.code, handler->path,
                                       parser_ctx->location);
   if (err2)
     {

Modified: subversion/trunk/subversion/libsvn_ra_serf/ra_serf.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/ra_serf.h?rev=1334446&r1=1334445&r2=1334446&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/ra_serf.h (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/ra_serf.h Sat May  5 16:42:10 2012
@@ -407,7 +407,9 @@ typedef struct svn_ra_serf__handler_t {
   void *response_baton;
 
   /* When REPONSE_HANDLER is invoked, the following fields will be set
-     based on the response header.  */
+     based on the response header. HANDLER_POOL must be non-NULL for these
+     values to be filled in. SLINE.REASON and LOCATION will be allocated
+     within HANDLER_POOL.  */
   serf_status_line sline;  /* The parsed Status-Line  */
   const char *location;  /* The Location: header, if any  */
 

Modified: subversion/trunk/subversion/libsvn_ra_serf/replay.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/replay.c?rev=1334446&r1=1334445&r2=1334446&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/replay.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/replay.c Sat May  5 16:42:10 2012
@@ -643,10 +643,6 @@ svn_ra_serf__replay(svn_ra_session_t *ra
   svn_ra_serf__xml_parser_t *parser_ctx;
   svn_error_t *err;
   const char *report_target;
-  /* We're not really interested in the status code here in replay, but
-     the XML parsing code will abort on error if it doesn't have a place
-     to store the response status code. */
-  int status_code;
 
   SVN_ERR(svn_ra_serf__report_resource(&report_target, session, NULL, pool));
 
@@ -678,7 +674,6 @@ svn_ra_serf__replay(svn_ra_session_t *ra
   parser_ctx->start = start_replay;
   parser_ctx->end = end_replay;
   parser_ctx->cdata = cdata_replay;
-  parser_ctx->status_code = &status_code;
   parser_ctx->done = &replay_ctx->done;
 
   handler->response_handler = svn_ra_serf__handle_xml_parser;

Modified: subversion/trunk/subversion/libsvn_ra_serf/update.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/update.c?rev=1334446&r1=1334445&r2=1334446&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/update.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/update.c Sat May  5 16:42:10 2012
@@ -2535,7 +2535,6 @@ finish_report(void *report_baton,
   svn_ra_serf__xml_parser_t *parser_ctx;
   const char *report_target;
   svn_boolean_t closed_root;
-  int status_code;
   svn_stringbuf_t *buf = NULL;
   apr_pool_t *iterpool = svn_pool_create(pool);
   svn_error_t *err;
@@ -2584,9 +2583,6 @@ finish_report(void *report_baton,
   parser_ctx->end = end_report;
   parser_ctx->cdata = cdata_report;
   parser_ctx->done = &report->done;
-  /* While we provide a location here to store the status code, we don't
-     do anything with it. The error in parser_ctx->error is sufficient. */
-  parser_ctx->status_code = &status_code;
 
   handler->response_handler = svn_ra_serf__handle_xml_parser;
   handler->response_baton = parser_ctx;

Modified: subversion/trunk/subversion/libsvn_ra_serf/util.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/util.c?rev=1334446&r1=1334445&r2=1334446&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/util.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/util.c Sat May  5 16:42:10 2012
@@ -1423,7 +1423,10 @@ svn_ra_serf__handle_xml_parser(serf_requ
   if (sl.code == 404 && ctx->ignore_errors == FALSE)
     {
       /* If our caller won't know about the 404, abort() for now. */
+#if 0
+      /* ### wrong thing to do anyways. and caller has HANDLER->SLINE.  */
       SVN_ERR_ASSERT(ctx->status_code);
+#endif
 
       add_done_item(ctx);
 



Mime
View raw message