Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@subversion.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
From: "Bert Huijben" <bert@qqmail.nl>
To: "'Daniel Shahaf'" <danielsh@elego.de>,
	<dev@subversion.apache.org>
Cc: <commits@subversion.apache.org>,
	"'Greg Stein'" <gstein@gmail.com>
References: <20120424060718.846F62388865@eris.apache.org>
 <20120425110341.GN10805@lp-shahaf.local>
In-Reply-To: <20120425110341.GN10805@lp-shahaf.local>
Subject: RE: svn commit: r1329563 -
 /subversion/trunk/subversion/libsvn_fs/editor.c
Date: Wed, 25 Apr 2012 13:08:53 +0200
Message-ID: <005201cd22d3$cdf287c0$69d79740$@qqmail.nl>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: AQHW7XdQgT1tkzqGXHovLWFSCKLUpgKL32JrloNtSuA=
Content-Language: nl


> -----Original Message-----
> From: Daniel Shahaf [mailto:danielsh@elego.de]
> Sent: woensdag 25 april 2012 13:04
> To: dev@subversion.apache.org
> Cc: commits@subversion.apache.org; Greg Stein
> Subject: Re: svn commit: r1329563 -
> /subversion/trunk/subversion/libsvn_fs/editor.c
> 
> gstein@apache.org wrote on Tue, Apr 24, 2012 at 06:07:18 -0000:
> > @@ -94,9 +210,11 @@ add_absent_cb(void *baton,
> >                svn_revnum_t replaces_rev,
> >                apr_pool_t *scratch_pool)
> >  {
> > -  struct edit_baton *eb = baton;
> > -
> > -  UNUSED(eb); SVN__NOT_IMPLEMENTED();
> > +  /* This is a programming error. Code should not attempt to create
these
> > +     kinds of nodes within the FS.  */
> > +  return svn_error_create(
> > +           SVN_ERR_UNSUPPORTED_FEATURE, NULL,
> > +           N_("The filesystem does not support 'absent' nodes"));
> >  }
> 
> Should be _() not N_()
> 
> Also: change the error text and code?  The use of "unsupported" sounds
> like a format upgrade would fix it.  How about one of those "is not
> allowed, and could indicate a bug in your client" errors?
> 
> SVN_ERR_EDITOR_INVALID_OPERATION maybe.

Yeas, something in SVN_ERR_FS or SVN_ERR_EDITOR would be much easier to
diagnose for api users than this error code that is usually used in
libsvn_client (and libsvn_ra)

	Bert