subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From julianf...@apache.org
Subject svn commit: r1331715 - in /subversion/trunk/subversion/libsvn_wc: entries.c wc_db.c
Date Sat, 28 Apr 2012 08:57:05 GMT
Author: julianfoad
Date: Sat Apr 28 08:57:05 2012
New Revision: 1331715

URL: http://svn.apache.org/viewvc?rev=1331715&view=rev
Log:
* subversion/libsvn_wc/entries.c,
  subversion/libsvn_wc/wc_db.c
  Annotate suspicious uses of svn_sqlite__bind_int64().

Modified:
    subversion/trunk/subversion/libsvn_wc/entries.c
    subversion/trunk/subversion/libsvn_wc/wc_db.c

Modified: subversion/trunk/subversion/libsvn_wc/entries.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/entries.c?rev=1331715&r1=1331714&r2=1331715&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_wc/entries.c (original)
+++ subversion/trunk/subversion/libsvn_wc/entries.c Sat Apr 28 08:57:05 2012
@@ -1444,6 +1444,7 @@ insert_node(svn_sqlite__db_t *sdb,
                                      node->repos_id));
       SVN_ERR(svn_sqlite__bind_text(stmt, 6,
                                     node->repos_relpath));
+      /* ### Shouldn't this use __bind_revnum?  (If not, say why.) */
       SVN_ERR(svn_sqlite__bind_int64(stmt, 7, node->revision));
     }
 

Modified: subversion/trunk/subversion/libsvn_wc/wc_db.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/wc_db.c?rev=1331715&r1=1331714&r2=1331715&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_wc/wc_db.c (original)
+++ subversion/trunk/subversion/libsvn_wc/wc_db.c Sat Apr 28 08:57:05 2012
@@ -1085,6 +1085,7 @@ insert_working_node(void *baton,
     {
       SVN_ERR(svn_sqlite__bind_int64(stmt, 5, piwb->original_repos_id));
       SVN_ERR(svn_sqlite__bind_text(stmt, 6, piwb->original_repos_relpath));
+      /* ### Shouldn't this use __bind_revnum?  (If not, say why.) */
       SVN_ERR(svn_sqlite__bind_int64(stmt, 7, piwb->original_revnum));
     }
 



Mime
View raw message