subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danie...@apache.org
Subject svn commit: r1330969 - /subversion/trunk/subversion/tests/cmdline/svntest/main.py
Date Thu, 26 Apr 2012 16:57:16 GMT
Author: danielsh
Date: Thu Apr 26 16:57:15 2012
New Revision: 1330969

URL: http://svn.apache.org/viewvc?rev=1330969&view=rev
Log:
Follow-up to r1330917: note a limitation.

* subversion/tests/cmdline/svntest/main.py
  (_line_contains_repos_diskpath): Document a potential shortcoming of the check as implemented.

Modified:
    subversion/trunk/subversion/tests/cmdline/svntest/main.py

Modified: subversion/trunk/subversion/tests/cmdline/svntest/main.py
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/svntest/main.py?rev=1330969&r1=1330968&r2=1330969&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/cmdline/svntest/main.py (original)
+++ subversion/trunk/subversion/tests/cmdline/svntest/main.py Thu Apr 26 16:57:15 2012
@@ -512,6 +512,10 @@ def run_command_stdin(command, error_exp
                                                         *varargs)
 
   def _line_contains_repos_diskpath(line):
+    # ### Note: this assumes that either svn-test-work isn't a symlink, 
+    # ### or the diskpath isn't realpath()'d somewhere on the way from
+    # ### the server's configuration and the client's stderr.  We could
+    # ### check for both the symlinked path and the realpath.
     return \
          os.path.join('cmdline', 'svn-test-work', 'repositories') in line \
       or os.path.join('cmdline', 'svn-test-work', 'local_tmp', 'repos') in line 



Mime
View raw message