subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1330499 - /subversion/trunk/subversion/libsvn_repos/hooks.c
Date Wed, 25 Apr 2012 19:23:12 GMT
Author: stsp
Date: Wed Apr 25 19:23:11 2012
New Revision: 1330499

URL: http://svn.apache.org/viewvc?rev=1330499&view=rev
Log:
* subversion/libsvn_repos/hooks.c
  (run_hook_cmd): Reintroduce the wrapping of errors returned from
   svn_io_run_cmd3() with the SVN_ERR_REPOS_HOOK_FAILURE error code.
   This wrapping was removed in r1330455.

Modified:
    subversion/trunk/subversion/libsvn_repos/hooks.c

Modified: subversion/trunk/subversion/libsvn_repos/hooks.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_repos/hooks.c?rev=1330499&r1=1330498&r2=1330499&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_repos/hooks.c (original)
+++ subversion/trunk/subversion/libsvn_repos/hooks.c Wed Apr 25 19:23:11 2012
@@ -240,6 +240,13 @@ run_hook_cmd(svn_string_t **result,
                           null_handle, TRUE, NULL, cmd_pool);
   if (!err)
     err = check_hook_result(name, cmd, &cmd_proc, cmd_proc.err, pool);
+  else
+    {
+      /* The command could not be started for some reason.
+       * Put a hook failure error into the error chain. */
+      err = svn_error_createf(SVN_ERR_REPOS_HOOK_FAILURE, err,
+                              _("Failed to start '%s' hook"), cmd);
+    }
 
   /* Hooks are fallible, and so hook failure is "expected" to occur at
      times.  When such a failure happens we still want to close the pipe



Mime
View raw message