Return-Path: X-Original-To: apmail-subversion-commits-archive@minotaur.apache.org Delivered-To: apmail-subversion-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6F638966C for ; Mon, 6 Feb 2012 14:51:12 +0000 (UTC) Received: (qmail 87633 invoked by uid 500); 6 Feb 2012 14:51:12 -0000 Delivered-To: apmail-subversion-commits-archive@subversion.apache.org Received: (qmail 87571 invoked by uid 500); 6 Feb 2012 14:51:11 -0000 Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@subversion.apache.org Delivered-To: mailing list commits@subversion.apache.org Received: (qmail 87557 invoked by uid 99); 6 Feb 2012 14:51:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Feb 2012 14:51:11 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [78.47.87.163] (HELO mx0.elegosoft.com) (78.47.87.163) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Feb 2012 14:51:03 +0000 Received: from localhost (localhost [127.0.0.1]) by mx0.elegosoft.com (Postfix) with ESMTP id AD924DE81F; Mon, 6 Feb 2012 15:50:42 +0100 (CET) Received: from mx0.elegosoft.com ([127.0.0.1]) by localhost (mx0.elegosoft.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2ZNCnWsNaoZG; Mon, 6 Feb 2012 15:50:42 +0100 (CET) Received: from daniel3.local (bzq-79-180-206-85.red.bezeqint.net [79.180.206.85]) by mx0.elegosoft.com (Postfix) with ESMTPSA id 4680FDE81D; Mon, 6 Feb 2012 15:50:42 +0100 (CET) Date: Mon, 6 Feb 2012 16:50:26 +0200 From: Daniel Shahaf To: dev@subversion.apache.org Cc: commits@subversion.apache.org, Hyrum K Wright Subject: Re: svn commit: r1241025 - in /subversion/trunk/subversion: include/svn_checksum.h libsvn_subr/checksum.c tests/libsvn_subr/checksum-test.c Message-ID: <20120206145026.GA13914@daniel3.local> References: <20120206144245.2FBEA23888D2@eris.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120206144245.2FBEA23888D2@eris.apache.org> User-Agent: Mutt/1.5.20 (2009-06-14) hwright@apache.org wrote on Mon, Feb 06, 2012 at 14:42:45 -0000: > + checksum = svn_checksum_empty_checksum(svn_checksum_md5, pool); > + SVN_TEST_ASSERT(svn_checksum_is_empty_checksum(checksum)); > + That doesn't test much -- both functions just call svn_md5__empty_string_digest() which returns a static constant. Perhaps actually construct an empty svn_string_t and checksum it?